Commit f6c9a2b
test: speed up parallel/test-tls-session-cache
This test had some unnecessary timeouts that made it run for a
much longer time than necessary (about 9 s rather than 0.2 s).
PR-URL: #18424
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 74a823c commit f6c9a2b
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -69,11 +69,11 @@ function doTest(testOptions, callback) { | |||
| 69 | 69 | server.on('newSession', function(id, data, cb) { | |
| 70 | 70 | ++newSessionCount; | |
| 71 | 71 | // Emulate asynchronous store | |
| 72 | - setTimeout(function() { | ||
| 72 | + setImmediate(() => { | ||
| 73 | 73 | assert.ok(!session); | |
| 74 | 74 | session = { id, data }; | |
| 75 | 75 | cb(); | |
| 76 | - }, 1000); | ||
| 76 | + }); | ||
| 77 | 77 | }); | |
| 78 | 78 | server.on('resumeSession', function(id, callback) { | |
| 79 | 79 | ++resumeCount; | |
@@ -89,9 +89,9 @@ function doTest(testOptions, callback) { | |||
| 89 | 89 | } | |
| 90 | 90 | ||
| 91 | 91 | // Just to check that async really works there | |
| 92 | - setTimeout(function() { | ||
| 92 | + setImmediate(() => { | ||
| 93 | 93 | callback(null, data); | |
| 94 | - }, 100); | ||
| 94 | + }); | ||
| 95 | 95 | }); | |
| 96 | 96 | ||
| 97 | 97 | server.listen(0, function() { | |
@@ -132,7 +132,7 @@ function doTest(testOptions, callback) { | |||
| 132 | 132 | } | |
| 133 | 133 | assert.strictEqual(code, 0); | |
| 134 | 134 | server.close(common.mustCall(function() { | |
| 135 | - setTimeout(callback, 100); | ||
| 135 | + setImmediate(callback); | ||
| 136 | 136 | })); | |
| 137 | 137 | })); | |
| 138 | 138 | } | |
0 commit comments