Commit f80bdc5
doc: deprecate modp1, modp2, and modp5 groups
These MODP groups should not be used by new applications, and existing
applications should attempt to migrate to stronger groups (or different
key exchange mechanisms).
Some applications still rely on these particular groups, so Node.js will
likely maintain support, directly or indirectly, for the foreseeable
future.
Refs: #44539
PR-URL: #44588
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 9fac6dd commit f80bdc5
3 files changed
Lines changed: 29 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1185,15 +1185,20 @@ const dh = createDiffieHellmanGroup('modp16'); | |||
| 1185 | 1185 | ||
| 1186 | 1186 | The following groups are supported: | |
| 1187 | 1187 | ||
| 1188 | - * `'modp1'` (768 bits, [RFC 2409][] Section 6.1) | ||
| 1189 | - * `'modp2'` (1024 bits, [RFC 2409][] Section 6.2) | ||
| 1190 | - * `'modp5'` (1536 bits, [RFC 3526][] Section 2) | ||
| 1191 | 1188 | * `'modp14'` (2048 bits, [RFC 3526][] Section 3) | |
| 1192 | 1189 | * `'modp15'` (3072 bits, [RFC 3526][] Section 4) | |
| 1193 | 1190 | * `'modp16'` (4096 bits, [RFC 3526][] Section 5) | |
| 1194 | 1191 | * `'modp17'` (6144 bits, [RFC 3526][] Section 6) | |
| 1195 | 1192 | * `'modp18'` (8192 bits, [RFC 3526][] Section 7) | |
| 1196 | 1193 | ||
| 1194 | + The following groups are still supported but deprecated (see [Caveats][]): | ||
| 1195 | + | ||
| 1196 | + * `'modp1'` (768 bits, [RFC 2409][] Section 6.1) <span class="deprecated-inline"></span> | ||
| 1197 | + * `'modp2'` (1024 bits, [RFC 2409][] Section 6.2) <span class="deprecated-inline"></span> | ||
| 1198 | + * `'modp5'` (1536 bits, [RFC 3526][] Section 2) <span class="deprecated-inline"></span> | ||
| 1199 | + | ||
| 1200 | + These deprecated groups might be removed in future versions of Node.js. | ||
| 1201 | + | ||
| 1197 | 1202 | ## Class: `ECDH` | |
| 1198 | 1203 | ||
| 1199 | 1204 | <!-- YAML | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3147,9 +3147,28 @@ Type: Documentation-only | |||
| 3147 | 3147 | ||
| 3148 | 3148 | The [`--trace-atomics-wait`][] flag is deprecated. | |
| 3149 | 3149 | ||
| 3150 | + ### DEP0167: Weak `DiffieHellmanGroup` instances (`modp1`, `modp2`, `modp5`) | ||
| 3151 | + | ||
| 3152 | + <!-- YAML | ||
| 3153 | + changes: | ||
| 3154 | + - version: REPLACEME | ||
| 3155 | + pr-url: https://github.com/nodejs/node/pull/44588 | ||
| 3156 | + description: Documentation-only deprecation. | ||
| 3157 | + --> | ||
| 3158 | + | ||
| 3159 | + Type: Documentation-only | ||
| 3160 | + | ||
| 3161 | + The well-known MODP groups `modp1`, `modp2`, and `modp5` are deprecated because | ||
| 3162 | + they are not secure against practical attacks. See [RFC 8247 Section 2.4][] for | ||
| 3163 | + details. | ||
| 3164 | + | ||
| 3165 | + These groups might be removed in future versions of Node.js. Applications that | ||
| 3166 | + rely on these groups should evaluate using stronger MODP groups instead. | ||
| 3167 | + | ||
| 3150 | 3168 | [Legacy URL API]: url.md#legacy-url-api | |
| 3151 | 3169 | [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf | |
| 3152 | 3170 | [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3 | |
| 3171 | + [RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4 | ||
| 3153 | 3172 | [WHATWG URL API]: url.md#the-whatwg-url-api | |
| 3154 | 3173 | [`"exports"` or `"main"` entry]: packages.md#main-entry-point-export | |
| 3155 | 3174 | [`--pending-deprecation`]: cli.md#--pending-deprecation | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -598,7 +598,8 @@ hr { | |||
| 598 | 598 | padding-left: 5rem; | |
| 599 | 599 | } | |
| 600 | 600 | ||
| 601 | - #toc .stability_0::after { | ||
| 601 | + #toc .stability_0::after, | ||
| 602 | + .deprecated-inline::after { | ||
| 602 | 603 | background-color: var(--red2); | |
| 603 | 604 | color: var(--white); | |
| 604 | 605 | content: "deprecated"; | |
0 commit comments