Commit f824e40
deps: remove usage of a C++20 feature from V8
We are not ready to compile with C++20 support yet.
This is only a DCHECK that can be removed without affecting the behavior
of release builds.
PR-URL: #49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #52465
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent d2c84c9 commit f824e40
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.4', | ||
| 40 | + 'v8_embedder_string': '-node.5', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -297,7 +297,6 @@ void JsonPrintAllSourceWithPositionsWasm( | |||
| 297 | 297 | os << "\"inlinings\": {"; | |
| 298 | 298 | for (size_t i = 0; i < positions.size(); ++i) { | |
| 299 | 299 | if (i != 0) os << ", "; | |
| 300 | - DCHECK(source_map.contains(positions[i].inlinee_func_index)); | ||
| 301 | 300 | size_t source_id = source_map.find(positions[i].inlinee_func_index)->second; | |
| 302 | 301 | SourcePosition inlining_pos = positions[i].caller_pos; | |
| 303 | 302 | os << '"' << i << "\": {\"inliningId\": " << i | |
0 commit comments