Commit f8337ce
test: make test-repl-syntax-error-stack agnostic
Revise test so that it does not depend on behavior specific to V8.
PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent c81b086 commit f8337ce
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,12 @@ process.on('exit', () => { | |||
| 11 | 11 | }); | |
| 12 | 12 | ||
| 13 | 13 | common.ArrayStream.prototype.write = function(output) { | |
| 14 | - if (/var foo bar;/.test(output)) | ||
| 14 | + // Matching only on a minimal piece of the stack because the string will vary | ||
| 15 | + // greatly depending on the JavaScript engine. V8 includes `;` because it | ||
| 16 | + // displays the line of code (`var foo bar;`) that is causing a problem. | ||
| 17 | + // ChakraCore does not display the line of code but includes `;` in the phrase | ||
| 18 | + // `Expected ';' `. | ||
| 19 | + if (/;/.test(output)) | ||
| 15 | 20 | found = true; | |
| 16 | 21 | }; | |
| 17 | 22 | ||
0 commit comments