Commit f83827d
src: use local isolate instead of args.GetIsolate
While stepping though SetupPromises I noticed that the environments
Isolate is used but not when creating the string "_setupPromises".
Is there a reason for using args.GetIsolate() instead of using the
environments isolate? I see that GetIsolate() is an inline call, but
could there be situations where it returns a different Isolate?
If not perhaps using the local isolate variable would be a litte
clearer.
PR-URL: #14768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent ee2ae0f commit f83827d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1281,7 +1281,7 @@ void SetupPromises(const FunctionCallbackInfo<Value>& args) { | |||
| 1281 | 1281 | ||
| 1282 | 1282 | env->process_object()->Delete( | |
| 1283 | 1283 | env->context(), | |
| 1284 | - FIXED_ONE_BYTE_STRING(args.GetIsolate(), "_setupPromises")).FromJust(); | ||
| 1284 | + FIXED_ONE_BYTE_STRING(isolate, "_setupPromises")).FromJust(); | ||
| 1285 | 1285 | } | |
| 1286 | 1286 | ||
| 1287 | 1287 | } // anonymous namespace | |
0 commit comments