Commit f97aa4b
src: remove unnecessary HandleScopes
API function callbacks run inside an implicit HandleScope. We don't
need to explicitly create one and in fact introduce some unnecessary
overhead when we do.
PR-URL: #7711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent 78dcf0d commit f97aa4b
1 file changed
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1822,8 +1822,6 @@ template <class Base> | |||
| 1822 | 1822 | void SSLWrap<Base>::SetOCSPResponse( | |
| 1823 | 1823 | const v8::FunctionCallbackInfo<v8::Value>& args) { | |
| 1824 | 1824 | #ifdef NODE__HAVE_TLSEXT_STATUS_CB | |
| 1825 | - HandleScope scope(args.GetIsolate()); | ||
| 1826 | - | ||
| 1827 | 1825 | Base* w; | |
| 1828 | 1826 | ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); | |
| 1829 | 1827 | Environment* env = w->env(); | |
@@ -1842,8 +1840,6 @@ template <class Base> | |||
| 1842 | 1840 | void SSLWrap<Base>::RequestOCSP( | |
| 1843 | 1841 | const v8::FunctionCallbackInfo<v8::Value>& args) { | |
| 1844 | 1842 | #ifdef NODE__HAVE_TLSEXT_STATUS_CB | |
| 1845 | - HandleScope scope(args.GetIsolate()); | ||
| 1846 | - | ||
| 1847 | 1843 | Base* w; | |
| 1848 | 1844 | ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); | |
| 1849 | 1845 | ||
@@ -1901,7 +1897,6 @@ void SSLWrap<Base>::GetEphemeralKeyInfo( | |||
| 1901 | 1897 | template <class Base> | |
| 1902 | 1898 | void SSLWrap<Base>::SetMaxSendFragment( | |
| 1903 | 1899 | const v8::FunctionCallbackInfo<v8::Value>& args) { | |
| 1904 | - HandleScope scope(args.GetIsolate()); | ||
| 1905 | 1900 | CHECK(args.Length() >= 1 && args[0]->IsNumber()); | |
| 1906 | 1901 | ||
| 1907 | 1902 | Base* w; | |
@@ -2204,7 +2199,6 @@ template <class Base> | |||
| 2204 | 2199 | void SSLWrap<Base>::GetALPNNegotiatedProto( | |
| 2205 | 2200 | const FunctionCallbackInfo<v8::Value>& args) { | |
| 2206 | 2201 | #ifdef TLSEXT_TYPE_application_layer_protocol_negotiation | |
| 2207 | - HandleScope scope(args.GetIsolate()); | ||
| 2208 | 2202 | Base* w; | |
| 2209 | 2203 | ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); | |
| 2210 | 2204 | ||
@@ -2226,7 +2220,6 @@ template <class Base> | |||
| 2226 | 2220 | void SSLWrap<Base>::SetALPNProtocols( | |
| 2227 | 2221 | const FunctionCallbackInfo<v8::Value>& args) { | |
| 2228 | 2222 | #ifdef TLSEXT_TYPE_application_layer_protocol_negotiation | |
| 2229 | - HandleScope scope(args.GetIsolate()); | ||
| 2230 | 2223 | Base* w; | |
| 2231 | 2224 | ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder()); | |
| 2232 | 2225 | Environment* env = w->env(); | |
0 commit comments