test: use spawnSync() full name in test-stdio-pipe-stderr · nodejs/node@f97f6c5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f97f6c5

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: use spawnSync() full name in test-stdio-pipe-stderr

test-stdio-pipe-stderr uses `spawnSync()` but renames it as `spawn()` which can be confusing. Rename it to `spawnSync()` for readability/maintainability. PR-URL: #41332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent d9465ae commit f97f6c5
Copy full SHA for f97f6c5

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-stdio-pipe-stderr.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-stdio-pipe-stderr.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stdio-pipe-stderr.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -4,7 +4,7 @@ const tmpdir = require('../common/tmpdir');
4	4	const assert = require('assert');
5	5	const fs = require('fs');
6	6	const join = require('path').join;
7		- const spawn = require('child_process').spawnSync;
	7	+ const { spawnSync } = require('child_process');
8	8
9	9	// Test that invoking node with require, and piping stderr to file,
10	10	// does not result in exception,
@@ -21,7 +21,7 @@ const stream = fs.createWriteStream(stderrOutputPath);
21	21	fs.writeFileSync(fakeModulePath, '', 'utf8');
22	22
23	23	stream.on('open', () => {
24		- spawn(process.execPath, {
	24	+ spawnSync(process.execPath, {
25	25	input: `require("${fakeModulePath.replace(/\\/g, '/')}")`,
26	26	stdio: ['pipe', 'pipe', stream]
27	27	});

0 commit comments

Comments

0 (0)