test: assert: add failing deepEqual test for faked boxed primitives · nodejs/node@f9ed5f3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f9ed5f3

Browse filesBrowse the repository at this point in the historyBrowse files

ljharb

authored and

targos

committed

test: assert: add failing deepEqual test for faked boxed primitives

PR-URL: #29029 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 375d1ee commit f9ed5f3
Copy full SHA for f9ed5f3

1 file changed

+12-2Lines changed: 12 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-assert-deep.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-assert-deep.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert-deep.js

+12-2Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -28,8 +28,7 @@ function re(literals, ...values) {
28	28	getters: true
29	29	});
30	30	// Need to escape special characters.
31		- result += str;
32		- result += literals[i + 1];
	31	+ result += `${str}${literals[i + 1]}`;
33	32	}
34	33	return {
35	34	code: 'ERR_ASSERTION',
@@ -605,11 +604,21 @@ assert.deepStrictEqual([ 1, 2, NaN, 4 ], [ 1, 2, NaN, 4 ]);
605	604	{
606	605	const boxedString = new String('test');
607	606	const boxedSymbol = Object(Symbol());
	607	+
	608	+ const fakeBoxedSymbol = {};
	609	+ Object.setPrototypeOf(fakeBoxedSymbol, Symbol.prototype);
	610	+ Object.defineProperty(
	611	+ fakeBoxedSymbol,
	612	+ Symbol.toStringTag,
	613	+ { enumerable: false, value: 'Symbol' }
	614	+ );
	615	+
608	616	assertNotDeepOrStrict(new Boolean(true), Object(false));
609	617	assertNotDeepOrStrict(Object(true), new Number(1));
610	618	assertNotDeepOrStrict(new Number(2), new Number(1));
611	619	assertNotDeepOrStrict(boxedSymbol, Object(Symbol()));
612	620	assertNotDeepOrStrict(boxedSymbol, {});
	621	+ assertNotDeepOrStrict(boxedSymbol, fakeBoxedSymbol);
613	622	assertDeepAndStrictEqual(boxedSymbol, boxedSymbol);
614	623	assertDeepAndStrictEqual(Object(true), Object(true));
615	624	assertDeepAndStrictEqual(Object(2), Object(2));
@@ -618,6 +627,7 @@ assert.deepStrictEqual([ 1, 2, NaN, 4 ], [ 1, 2, NaN, 4 ]);
618	627	assertNotDeepOrStrict(boxedString, Object('test'));
619	628	boxedSymbol.slow = true;
620	629	assertNotDeepOrStrict(boxedSymbol, {});
	630	+ assertNotDeepOrStrict(boxedSymbol, fakeBoxedSymbol);
621	631	}
622	632
623	633	// Minus zero

0 commit comments

Comments

0 (0)