dns: throw a TypeError in lookupService with invalid port · nodejs/node@fa0457e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fa0457e

Browse filesBrowse the repository at this point in the historyBrowse files

evanlucas

authored and

rvagg

committed

dns: throw a TypeError in lookupService with invalid port

Previously, port was assumed to be a number and would cause an abort in cares_wrap. This change throws a TypeError if port is not a number before we actually hit C++. Fixes: #4837 PR-URL: #4839 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>

1 parent a1af6fc commit fa0457e
Copy full SHA for fa0457e

2 files changed

+19Lines changed: 19 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • dns.js
• test/parallel
  • test-dns.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/dns.js‎

Copy file name to clipboardExpand all lines: lib/dns.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -189,6 +189,9 @@ exports.lookupService = function(host, port, callback) {
189	189	if (cares.isIP(host) === 0)
190	190	throw new TypeError('host needs to be a valid IP address');
191	191
	192	+ if (typeof port !== 'number')
	193	+ throw new TypeError(`port argument must be a number, got "${port}"`);
	194	+
192	195	callback = makeAsync(callback);
193	196
194	197	var req = new GetNameInfoReqWrap();

Collapse file

‎test/parallel/test-dns.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns.js

+16Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -145,3 +145,19 @@ assert.doesNotThrow(function() {
145	145	hints: dns.ADDRCONFIG | dns.V4MAPPED
146	146	}, noop);
147	147	});
	148	+
	149	+ assert.throws(function() {
	150	+ dns.lookupService('0.0.0.0');
	151	+ }, /invalid arguments/);
	152	+
	153	+ assert.throws(function() {
	154	+ dns.lookupService('fasdfdsaf', 0, noop);
	155	+ }, /host needs to be a valid IP address/);
	156	+
	157	+ assert.throws(function() {
	158	+ dns.lookupService('0.0.0.0', '0', noop);
	159	+ }, /port argument must be a number, got "0"/);
	160	+
	161	+ assert.doesNotThrow(function() {
	162	+ dns.lookupService('0.0.0.0', 0, noop);
	163	+ });

0 commit comments

Comments

0 (0)