Commit fa0e8d7
crypto: avoid std::function
Using a template type lets the compiler choose an appropriate type
that likely is more efficient than std::function since the lambda
expressions at the call sites do not capture any values from surrounding
scopes.
PR-URL: #53683
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>1 parent ef5dabd commit fa0e8d7
1 file changed
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -75,12 +75,11 @@ void GetKeyFormatAndTypeFromJs( | |||
| 75 | 75 | *offset += 2; | |
| 76 | 76 | } | |
| 77 | 77 | ||
| 78 | - ParseKeyResult TryParsePublicKey( | ||
| 79 | - EVPKeyPointer* pkey, | ||
| 80 | - const BIOPointer& bp, | ||
| 81 | - const char* name, | ||
| 82 | - // NOLINTNEXTLINE(runtime/int) | ||
| 83 | - const std::function<EVP_PKEY*(const unsigned char** p, long l)>& parse) { | ||
| 78 | + template <typename F> | ||
| 79 | + ParseKeyResult TryParsePublicKey(EVPKeyPointer* pkey, | ||
| 80 | + const BIOPointer& bp, | ||
| 81 | + const char* name, | ||
| 82 | + F&& parse) { | ||
| 84 | 83 | unsigned char* der_data; | |
| 85 | 84 | long der_len; // NOLINT(runtime/int) | |
| 86 | 85 | ||
0 commit comments