doc: use console.error for error case in timers and tls · nodejs/node@fa5b65e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fa5b65e

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

juanarbol

committed

doc: use console.error for error case in timers and tls

console.error is more suitable than console.log for error case. PR-URL: #46002 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent aec340b commit fa5b65e
Copy full SHA for fa5b65e

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • timers.md
  • tls.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/timers.md‎

Copy file name to clipboardExpand all lines: doc/api/timers.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -278,7 +278,7 @@ setImmediatePromise('foobar', { signal })
278	278	.then(console.log)
279	279	.catch((err) => {
280	280	if (err.name === 'AbortError')
281		- console.log('The immediate was aborted');
	281	+ console.error('The immediate was aborted');
282	282	});
283	283
284	284	ac.abort();
@@ -296,7 +296,7 @@ setTimeoutPromise(1000, 'foobar', { signal })
296	296	.then(console.log)
297	297	.catch((err) => {
298	298	if (err.name === 'AbortError')
299		- console.log('The timeout was aborted');
	299	+ console.error('The timeout was aborted');
300	300	});
301	301
302	302	ac.abort();

Collapse file

‎doc/api/tls.md‎

Copy file name to clipboardExpand all lines: doc/api/tls.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -29,7 +29,7 @@ let tls;
29	29	try {
30	30	tls = require('node:tls');
31	31	} catch (err) {
32		- console.log('tls support is disabled!');
	32	+ console.error('tls support is disabled!');
33	33	}
34	34	```
35	35
@@ -47,7 +47,7 @@ let tls;
47	47	try {
48	48	tls = await import('node:tls');
49	49	} catch (err) {
50		- console.log('tls support is disabled!');
	50	+ console.error('tls support is disabled!');
51	51	}
52	52	```
53	53

0 commit comments

Comments

0 (0)