Commit fa8315c
test: refactor test-process-kill-null
Use `common.mustCall()` instead of `called` variable.
PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 9c96d7f commit fa8315c
1 file changed
Lines changed: 6 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,27 +1,21 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - require('../common'); | ||
| 2 | + const { mustCall } = require('../common'); | ||
| 3 | 3 | const assert = require('assert'); | |
| 4 | - const spawn = require('child_process').spawn; | ||
| 4 | + const { spawn } = require('child_process'); | ||
| 5 | 5 | ||
| 6 | 6 | const cat = spawn('cat'); | |
| 7 | - let called; | ||
| 8 | 7 | ||
| 9 | 8 | assert.ok(process.kill(cat.pid, 0)); | |
| 10 | 9 | ||
| 11 | - cat.on('exit', function() { | ||
| 10 | + cat.on('exit', mustCall(function() { | ||
| 12 | 11 | assert.throws(function() { | |
| 13 | 12 | process.kill(cat.pid, 0); | |
| 14 | 13 | }, Error); | |
| 15 | - }); | ||
| 14 | + })); | ||
| 16 | 15 | ||
| 17 | - cat.stdout.on('data', function() { | ||
| 18 | - called = true; | ||
| 16 | + cat.stdout.on('data', mustCall(function() { | ||
| 19 | 17 | process.kill(cat.pid, 'SIGKILL'); | |
| 20 | - }); | ||
| 18 | + })); | ||
| 21 | 19 | ||
| 22 | 20 | // EPIPE when null sig fails | |
| 23 | 21 | cat.stdin.write('test'); | |
| 24 | - | ||
| 25 | - process.on('exit', function() { | ||
| 26 | - assert.ok(called); | ||
| 27 | - }); | ||
0 commit comments