Commit fa940cf
fs: remove unused branches
In a few places the code was refactored to use `maybeCallback` which
always returns a function. Checking for `if (callback)` always returns
true anyway.
PR-URL: #4795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent 386ad7e commit fa940cf
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1146,16 +1146,16 @@ function writeAll(fd, isUserFd, buffer, offset, length, position, callback_) { | |||
| 1146 | 1146 | fs.write(fd, buffer, offset, length, position, function(writeErr, written) { | |
| 1147 | 1147 | if (writeErr) { | |
| 1148 | 1148 | if (isUserFd) { | |
| 1149 | - if (callback) callback(writeErr); | ||
| 1149 | + callback(writeErr); | ||
| 1150 | 1150 | } else { | |
| 1151 | 1151 | fs.close(fd, function() { | |
| 1152 | - if (callback) callback(writeErr); | ||
| 1152 | + callback(writeErr); | ||
| 1153 | 1153 | }); | |
| 1154 | 1154 | } | |
| 1155 | 1155 | } else { | |
| 1156 | 1156 | if (written === length) { | |
| 1157 | 1157 | if (isUserFd) { | |
| 1158 | - if (callback) callback(null); | ||
| 1158 | + callback(null); | ||
| 1159 | 1159 | } else { | |
| 1160 | 1160 | fs.close(fd, callback); | |
| 1161 | 1161 | } | |
@@ -1193,7 +1193,7 @@ fs.writeFile = function(path, data, options, callback_) { | |||
| 1193 | 1193 | ||
| 1194 | 1194 | fs.open(path, flag, options.mode, function(openErr, fd) { | |
| 1195 | 1195 | if (openErr) { | |
| 1196 | - if (callback) callback(openErr); | ||
| 1196 | + callback(openErr); | ||
| 1197 | 1197 | } else { | |
| 1198 | 1198 | writeFd(fd, false); | |
| 1199 | 1199 | } | |
0 commit comments