test,crypto: fix conditional SHA3-* skip on BoringSSL · nodejs/node@fabf8e4 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fabf8e4

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

aduh95

committed

test,crypto: fix conditional SHA3-* skip on BoringSSL

PR-URL: #60379 Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 4b85066 commit fabf8e4
Copy full SHA for fabf8e4

1 file changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-webcrypto-sign-verify-rsa.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-webcrypto-sign-verify-rsa.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-webcrypto-sign-verify-rsa.js

+6-6Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -241,13 +241,13 @@ async function testSaltLength(keyLength, hash, hLen) {
241	241	['SHA-256', 32],
242	242	['SHA-384', 48],
243	243	['SHA-512', 64],
244		- ['SHA3-256', 32],
245		- ['SHA3-384', 48],
246		- ['SHA3-512', 64],
	244	+ ...(!process.features.openssl_is_boringssl ? [
	245	+ ['SHA3-256', 32],
	246	+ ['SHA3-384', 48],
	247	+ ['SHA3-512', 64],
	248	+ ] : []),
247	249	]) {
248		- if (hash.startsWith('SHA-3') && !process.features.openssl_is_boringssl) {
249		- variations.push(testSaltLength(keyLength, hash, hLen));
250		- }
	250	+ variations.push(testSaltLength(keyLength, hash, hLen));
251	251	}
252	252	}
253	253

0 commit comments

Comments

0 (0)