Commit faf8ada
deps: V8: cherry-pick f6bef09b3b0a
Original commit message:
[turboshaft] initialize constant_value_ to an empty value
gcc-10 seems to have a bug were not initializing this value
throws this compilation error:
```
src/compiler/turboshaft/assembler.h:680:16: error: ‘<anonymous>’ is used uninitialized in this function [-Werror=uninitialized]
680 | return Get();
```
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465
Bug: v8:12783
Change-Id: I7a5fee5009b866a801326fba734c156c3cfdb1b0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5503350
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#93675}
Refs: v8/v8@f6bef09
PR-URL: #52802
Fixes: #52661
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>1 parent 850ff02 commit faf8ada
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.11', | ||
| 40 | + 'v8_embedder_string': '-node.12', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -480,7 +480,7 @@ class ConstOrV { | |||
| 480 | 480 | template <typename U, | |
| 481 | 481 | typename = std::enable_if_t<std::is_constructible_v<V<T>, V<U>>>> | |
| 482 | 482 | ConstOrV(V<U> index) // NOLINT(runtime/explicit) | |
| 483 | - : constant_value_(), value_(index) {} | ||
| 483 | + : constant_value_(std::nullopt), value_(index) {} | ||
| 484 | 484 | ||
| 485 | 485 | bool is_constant() const { return constant_value_.has_value(); } | |
| 486 | 486 | constant_type constant_value() const { | |
0 commit comments