Commit fb98fa4
test_runner: refactor Promise chain in run()
This commit refactors the chain of functions in run() to use an
async function instead of creating an awkward primordial-based
Promise chain.
PR-URL: #55958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>1 parent 18c9496 commit fb98fa4
1 file changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,7 +17,6 @@ const { | |||
| 17 | 17 | ArrayPrototypeSort, | |
| 18 | 18 | ObjectAssign, | |
| 19 | 19 | PromisePrototypeThen, | |
| 20 | - PromiseResolve, | ||
| 21 | 20 | PromiseWithResolvers, | |
| 22 | 21 | SafeMap, | |
| 23 | 22 | SafePromiseAll, | |
@@ -798,9 +797,17 @@ function run(options = kEmptyObject) { | |||
| 798 | 797 | } | |
| 799 | 798 | } | |
| 800 | 799 | ||
| 801 | - const setupPromise = PromiseResolve(setup?.(root.reporter)); | ||
| 802 | - PromisePrototypeThen(PromisePrototypeThen(PromisePrototypeThen(setupPromise, runFiles), postRun), teardown); | ||
| 800 | + const runChain = async () => { | ||
| 801 | + if (typeof setup === 'function') { | ||
| 802 | + await setup(root.reporter); | ||
| 803 | + } | ||
| 804 | + | ||
| 805 | + await runFiles(); | ||
| 806 | + postRun?.(); | ||
| 807 | + teardown?.(); | ||
| 808 | + }; | ||
| 803 | 809 | ||
| 810 | + runChain(); | ||
| 804 | 811 | return root.reporter; | |
| 805 | 812 | } | |
| 806 | 813 | ||
0 commit comments