Commit fbc9ef8
src: disable stdio buffering
Disable stdio buffering, it interacts poorly with printf() calls from
elsewhere in the program (e.g., any logging from V8.) Unbreaks among
other things the `--trace_debug_json` switch.
Undoes commit 0966ab9 ("src: force line buffering for stderr"), which
in retrospect is not a proper fix. Turning on line buffering fixed a
flaky test on SmartOS but the test wasn't failing on other platforms,
where stderr wasn't line-buffered either. Mark the test flaky again,
it failed once in a run of 333 tries on the smartos-64 buildbot.
Disabling buffering should be safe even when mixed with non-blocking
stdio I/O because libuv goes to great lengths to reopen the tty file
descriptors and falls back to blocking I/O when that fails.
PR-URL: #7610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent df697c4 commit fbc9ef8
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -50,7 +50,10 @@ int wmain(int argc, wchar_t *wargv[]) { | |||
| 50 | 50 | #else | |
| 51 | 51 | // UNIX | |
| 52 | 52 | int main(int argc, char *argv[]) { | |
| 53 | - setvbuf(stderr, NULL, _IOLBF, 1024); | ||
| 53 | + // Disable stdio buffering, it interacts poorly with printf() | ||
| 54 | + // calls elsewhere in the program (e.g., any logging from V8.) | ||
| 55 | + setvbuf(stdout, nullptr, _IONBF, 0); | ||
| 56 | + setvbuf(stderr, nullptr, _IONBF, 0); | ||
| 54 | 57 | return node::Start(argc, argv); | |
| 55 | 58 | } | |
| 56 | 59 | #endif | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -22,6 +22,7 @@ test-tls-connect-address-family : PASS,FLAKY | |||
| 22 | 22 | [$system==macos] | |
| 23 | 23 | ||
| 24 | 24 | [$system==solaris] # Also applies to SmartOS | |
| 25 | + test-debug-signal-cluster : PASS,FLAKY | ||
| 25 | 26 | ||
| 26 | 27 | [$system==freebsd] | |
| 27 | 28 | ||
0 commit comments