Commit fbcf602
test: make test-memory-usage predictable
The current test relies on undeterministic behavior from V8 GC, and on
newer versions of V8 this test ocasionally fails because that behavior
changed. Prevent that from happening using --predictable-gc-schedule.
If this test fails in the future, it should fail consistently instead of
ocasionally, which should help debug.
Ref: nodejs/node-v8#144 (comment)
Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
PR-URL: #32239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>1 parent 963ce08 commit fbcf602
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,7 +19,7 @@ | |||
| 19 | 19 | // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | |
| 20 | 20 | // USE OR OTHER DEALINGS IN THE SOFTWARE. | |
| 21 | 21 | ||
| 22 | - // Flags: --no-concurrent-array-buffer-freeing | ||
| 22 | + // Flags: --predictable-gc-schedule | ||
| 23 | 23 | 'use strict'; | |
| 24 | 24 | const common = require('../common'); | |
| 25 | 25 | const assert = require('assert'); | |
0 commit comments