build: fix GetCurrentThreadStackLimits error on Windows on Arm · nodejs/node@fc03224 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 591
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fc03224

Browse filesBrowse the repository at this point in the historyBrowse files

richard-townsend-arm

authored and

codebytere

committed

build: fix GetCurrentThreadStackLimits error on Windows on Arm

GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: #33511 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent d8aeafb commit fc03224
Copy full SHA for fc03224

1 file changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools/v8_gypfiles
  • v8.gyp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1081,8 +1081,10 @@
1081	1081	'<(V8_ROOT)/src/base/platform/platform-win32.cc',
1082	1082	'<(V8_ROOT)/src/base/win32-headers.h',
1083	1083	],
1084		-
1085		- 'defines': ['_CRT_RAND_S'], # for rand_s()
	1084	+ 'conditions': [['target_arch == "arm64"', {
	1085	+ 'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
	1086	+ }]],
	1087	+ 'defines': ['_CRT_RAND_S'], # for rand_s()
1086	1088	'direct_dependent_settings': {
1087	1089	'msvs_settings': {
1088	1090	'VCLinkerTool': {

0 commit comments

Comments

0 (0)