Commit fcaa2c8
build: fix GN build on macOS
use_gold is not defined on macOS.
PR-URL: #56141
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent cfbdff7 commit fcaa2c8
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -263,7 +263,7 @@ template("node_gn_build") { | |||
| 263 | 263 | ldflags = [ "/OPT:NOICF" ] # link.exe, but also lld-link.exe. | |
| 264 | 264 | } else if (is_apple && !use_lld) { | |
| 265 | 265 | ldflags = [ "-Wl,-no_deduplicate" ] # ld64. | |
| 266 | - } else if (use_gold || use_lld) { | ||
| 266 | + } else if ((!is_apple && use_gold) || use_lld) { | ||
| 267 | 267 | ldflags = [ "-Wl,--icf=none" ] | |
| 268 | 268 | } | |
| 269 | 269 | } | |
0 commit comments