lib,src,test: lint codebase according new rules for v18.x · nodejs/node@fcf3781 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fcf3781

Browse filesBrowse the repository at this point in the historyBrowse files

juanarbol

authored and

danielleadams

committed

lib,src,test: lint codebase according new rules for v18.x

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #48697 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent 2262653 commit fcf3781
Copy full SHA for fcf3781

5 files changed

+5-14Lines changed: 5 additions & 14 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • fs
    • promises.js
  • modules/esm
    • loader.js
• pyproject.toml
• src
  • node_builtins.cc
• test/common
  • wpt.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -110,14 +110,6 @@ const {
110	110	JSTransferable, kDeserialize, kTransfer, kTransferList,
111	111	} = require('internal/worker/js_transferable');
112	112
113		- const {
114		- newReadableStreamFromStreamBase,
115		- } = require('internal/webstreams/adapters');
116		-
117		- const {
118		- readableStreamCancel,
119		- } = require('internal/webstreams/readablestream');
120		-
121	113	const getDirectoryEntriesPromise = promisify(getDirents);
122	114	const validateRmOptionsPromise = promisify(validateRmOptions);
123	115

Collapse file

‎lib/internal/modules/esm/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -549,7 +549,6 @@ class ESMLoader {
549	549	* until it reaches the bottom or short-circuits.
550	550	* @param {URL['href']} url The URL/path of the module to be loaded
551	551	* @param {object} context Metadata about the module
552		- *
553	552	* @returns {{ format: ModuleFormat, source: ModuleSource }}
554	553	*/
555	554	async load(url, context = {}) {

Collapse file

‎pyproject.toml‎

Copy file name to clipboardExpand all lines: pyproject.toml

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -28,6 +28,7 @@ ignore = [
28	28	"PLC1901",
29	29	"RUF005",
30	30	"RUF100",
	31	+ "RUF012",
31	32	]
32	33	line-length = 172
33	34	target-version = "py37"

Collapse file

‎src/node_builtins.cc‎

Copy file name to clipboardExpand all lines: src/node_builtins.cc

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -365,9 +365,10 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
365	365	return scope.Escape(fun);
366	366	}
367	367
368		- MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
369		- const char* id,
370		- Environment* optional_env) {
	368	+ MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
	369	+ Local<Context> context,
	370	+ const char* id,
	371	+ Environment* optional_env) {
371	372	Result result;
372	373	std::vector<Local<String>> parameters;
373	374	Isolate* isolate = context->GetIsolate();

Collapse file

‎test/common/wpt.js‎

Copy file name to clipboardExpand all lines: test/common/wpt.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -715,7 +715,6 @@ class WPTRunner {
715	715	/**
716	716	* Report the status of each specific test case (there could be multiple
717	717	* in one test file).
718		- *
719	718	* @param {string} filename
720	719	* @param {Test} test The Test object returned by WPT harness
721	720	*/
@@ -735,7 +734,6 @@ class WPTRunner {
735	734
736	735	/**
737	736	* Report the status of each WPT test (one per file)
738		- *
739	737	* @param {string} filename
740	738	* @param {object} harnessStatus - The status object returned by WPT harness.
741	739	*/

0 commit comments

Comments

0 (0)