Commit fd166a8
committed
events: return values directly in listeners
Each conditional branch in EventEmitter.prototype.listeners assigns
its return value to a variable ret which is returned at the end.
Instead just return from within each branch. This is both clearer
and more performant.
events/ee-listeners.js n=5000000 3.65 % *** 3.359171e-10
PR-URL: #16212
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent c8d4ff1 commit fd166a8
1 file changed
Lines changed: 10 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -481,23 +481,19 @@ EventEmitter.prototype.removeAllListeners = | |||
| 481 | 481 | }; | |
| 482 | 482 | ||
| 483 | 483 | EventEmitter.prototype.listeners = function listeners(type) { | |
| 484 | - var evlistener; | ||
| 485 | - var ret; | ||
| 486 | - var events = this._events; | ||
| 484 | + const events = this._events; | ||
| 487 | 485 | ||
| 488 | 486 | if (events === undefined) | |
| 489 | - ret = []; | ||
| 490 | - else { | ||
| 491 | - evlistener = events[type]; | ||
| 492 | - if (evlistener === undefined) | ||
| 493 | - ret = []; | ||
| 494 | - else if (typeof evlistener === 'function') | ||
| 495 | - ret = [evlistener.listener || evlistener]; | ||
| 496 | - else | ||
| 497 | - ret = unwrapListeners(evlistener); | ||
| 498 | - } | ||
| 487 | + return []; | ||
| 499 | 488 | ||
| 500 | - return ret; | ||
| 489 | + const evlistener = events[type]; | ||
| 490 | + if (evlistener === undefined) | ||
| 491 | + return []; | ||
| 492 | + | ||
| 493 | + if (typeof evlistener === 'function') | ||
| 494 | + return [evlistener.listener || evlistener]; | ||
| 495 | + | ||
| 496 | + return unwrapListeners(evlistener); | ||
| 501 | 497 | }; | |
| 502 | 498 | ||
| 503 | 499 | EventEmitter.listenerCount = function(emitter, type) { | |
0 commit comments