Commit fd1ffe4
v8: fix --always-opt bug
Don't try to optimize known-unoptimizable functions when --always-opt
is specified on the command line, it makes Crankshaft emit wrong code.
This was fixed upstream when improved WASM support was introduced but
that specific change can't be back-ported because it depends on prior
work that doesn't exist in V8 5.1. Ergo, I decided to redo the fix
from scratch.
PR-URL: #9293
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent bad0d93 commit fd1ffe4
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1926,7 +1926,10 @@ void Compiler::PostInstantiation(Handle<JSFunction> function, | |||
| 1926 | 1926 | PretenureFlag pretenure) { | |
| 1927 | 1927 | Handle<SharedFunctionInfo> shared(function->shared()); | |
| 1928 | 1928 | ||
| 1929 | - if (FLAG_always_opt && shared->allows_lazy_compilation()) { | ||
| 1929 | + if (FLAG_always_opt && | ||
| 1930 | + shared->allows_lazy_compilation() && | ||
| 1931 | + !shared->optimization_disabled() && | ||
| 1932 | + !shared->dont_crankshaft()) { | ||
| 1930 | 1933 | function->MarkForOptimization(); | |
| 1931 | 1934 | } | |
| 1932 | 1935 | ||
0 commit comments