Commit fd5fed1
dgram: reset bind state before emitting error
This was previously done inconsistently, sometimes before, sometimes
after emitting the event.
PR-URL: #30210
Fixes: #30209
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e1a1244 commit fd5fed1
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -240,8 +240,8 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) { | |||
| 240 | 240 | }, (err) => { | |
| 241 | 241 | // Callback to handle error. | |
| 242 | 242 | const ex = errnoException(err, 'open'); | |
| 243 | - this.emit('error', ex); | ||
| 244 | 243 | state.bindState = BIND_STATE_UNBOUND; | |
| 244 | + this.emit('error', ex); | ||
| 245 | 245 | }); | |
| 246 | 246 | return this; | |
| 247 | 247 | } | |
@@ -309,8 +309,8 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) { | |||
| 309 | 309 | }, (err) => { | |
| 310 | 310 | // Callback to handle error. | |
| 311 | 311 | const ex = exceptionWithHostPort(err, 'bind', ip, port); | |
| 312 | - this.emit('error', ex); | ||
| 313 | 312 | state.bindState = BIND_STATE_UNBOUND; | |
| 313 | + this.emit('error', ex); | ||
| 314 | 314 | }); | |
| 315 | 315 | } else { | |
| 316 | 316 | if (!state.handle) | |
@@ -319,8 +319,8 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) { | |||
| 319 | 319 | const err = state.handle.bind(ip, port || 0, flags); | |
| 320 | 320 | if (err) { | |
| 321 | 321 | const ex = exceptionWithHostPort(err, 'bind', ip, port); | |
| 322 | - this.emit('error', ex); | ||
| 323 | 322 | state.bindState = BIND_STATE_UNBOUND; | |
| 323 | + this.emit('error', ex); | ||
| 324 | 324 | // Todo: close? | |
| 325 | 325 | return; | |
| 326 | 326 | } | |
0 commit comments