Commit fd99b17
tools: make utils.SearchFiles deterministic
`glob.glob` on Linux returns files in the order returned by the
filesystem driver, and the output from this function is stuffed by
the Electron build process straight into the `config.gypi` header,
causing non-reproducible builds.
See this log for an example of the nondeterminism:
https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out
PR-URL: #44496
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>1 parent d762a34 commit fd99b17
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -112,4 +112,4 @@ def SearchFiles(dir, ext): | |||
| 112 | 112 | list = glob.glob(dir+ '/**/*.' + ext, recursive=True) | |
| 113 | 113 | if sys.platform == 'win32': | |
| 114 | 114 | list = [ x.replace('\\', '/')for x in list] | |
| 115 | - return list | ||
| 115 | + return sorted(list) | ||
0 commit comments