Commit fdae57f
test: fix some tests when path contains %
Tests should pass even if the path where the repo is cloned contains
URL-significant chars.
PR-URL: #55082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>1 parent 4352d9c commit fdae57f
3 files changed
Lines changed: 4 additions & 4 deletions
File tree
- test
- common
- es-module
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -255,8 +255,8 @@ class InspectorSession { | |||
| 255 | 255 | const callFrame = message.params.callFrames[0]; | |
| 256 | 256 | const location = callFrame.location; | |
| 257 | 257 | const scriptPath = this._scriptsIdsByUrl.get(location.scriptId); | |
| 258 | - assert.strictEqual(scriptPath.toString(), | ||
| 259 | - expectedScriptPath.toString(), | ||
| 258 | + assert.strictEqual(decodeURIComponent(scriptPath), | ||
| 259 | + decodeURIComponent(expectedScriptPath), | ||
| 260 | 260 | `${scriptPath} !== ${expectedScriptPath}`); | |
| 261 | 261 | assert.strictEqual(location.lineNumber, line); | |
| 262 | 262 | return true; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -45,7 +45,7 @@ assert.deepStrictEqual( | |||
| 45 | 45 | { default: 'some://weird/protocol' }, | |
| 46 | 46 | ); | |
| 47 | 47 | assert.deepStrictEqual( | |
| 48 | - { ...await import(`data:text/javascript,export default import.meta.resolve("baz/", ${JSON.stringify(fixtures)})`) }, | ||
| 48 | + { ...await import(`data:text/javascript,export default import.meta.resolve("baz/", ${encodeURIComponent(JSON.stringify(fixtures))})`) }, | ||
| 49 | 49 | { default: fixtures + 'node_modules/baz/' }, | |
| 50 | 50 | ); | |
| 51 | 51 | assert.deepStrictEqual( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -822,7 +822,7 @@ describe('Loader hooks', { concurrency: !process.env.TEST_PARALLEL }, () => { | |||
| 822 | 822 | const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [ | |
| 823 | 823 | '--no-warnings', | |
| 824 | 824 | '--experimental-loader', | |
| 825 | - `data:text/javascript,const fixtures=${JSON.stringify(fixtures.path('empty.js'))};export ${ | ||
| 825 | + `data:text/javascript,const fixtures=${encodeURI(JSON.stringify(fixtures.path('empty.js')))};export ${ | ||
| 826 | 826 | encodeURIComponent(function resolve(s, c, n) { | |
| 827 | 827 | if (s.endsWith('entry-point')) { | |
| 828 | 828 | return { | |
0 commit comments