Commit fdb4a6c
test: skip the test with proper TAP message
On Windows, the test simply returns which will be counted as passed.
The test actually skips the rest of the test. So proper TAP message has
to be included while skipping.
This patch uses `common.skip` rather than `console.log` to print the
skip messages.
PR-URL: #11584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent ed6d741 commit fdb4a6c
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,8 +4,7 @@ const common = require('../common'); | |||
| 4 | 4 | ||
| 5 | 5 | // FIXME add sunos support | |
| 6 | 6 | if (common.isSunOS) { | |
| 7 | - console.log(`1..0 # Skipped: Unsupported platform [${process.platform}]`); | ||
| 8 | - return; | ||
| 7 | + return common.skip(`Unsupported platform [${process.platform}]`); | ||
| 9 | 8 | } | |
| 10 | 9 | ||
| 11 | 10 | const assert = require('assert'); | |
@@ -22,8 +21,9 @@ process.title = title; | |||
| 22 | 21 | assert.strictEqual(process.title, title); | |
| 23 | 22 | ||
| 24 | 23 | // Test setting the title but do not try to run `ps` on Windows. | |
| 25 | - if (common.isWindows) | ||
| 26 | - return; | ||
| 24 | + if (common.isWindows) { | ||
| 25 | + return common.skip('Windows does not have "ps" utility'); | ||
| 26 | + } | ||
| 27 | 27 | ||
| 28 | 28 | exec(`ps -p ${process.pid} -o args=`, function callback(error, stdout, stderr) { | |
| 29 | 29 | assert.ifError(error); | |
0 commit comments