Commit fdc6a96
doc: revise CI text in collaborator guide
Minor clarifications to text. For example, this moves the "(green or
yellow)" parenthetical closer to the text to which it applies. (It
applies only to Jenkins CI.)
PR-URL: #37526
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>1 parent c62a134 commit fdc6a96
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -210,11 +210,11 @@ the comment anyway to avoid any doubt. | |||
| 210 | 210 | All fixes must have a test case which demonstrates the defect. The test should | |
| 211 | 211 | fail before the change, and pass after the change. | |
| 212 | 212 | ||
| 213 | - Do not land any pull requests without a passing (green or yellow) CI run. | ||
| 214 | - A green GitHub Actions CI result is required. A passing | ||
| 215 | - [Jenkins CI](https://ci.nodejs.org/) is also required if PR contains changes | ||
| 216 | - that will affect the `node` binary. This is critical as GitHub Actions CI does | ||
| 217 | - not cover all the environments supported by Node.js. | ||
| 213 | + Do not land any pull requests without the necessary passing CI runs. | ||
| 214 | + A passing (green) GitHub Actions CI result is required. A passing (green or | ||
| 215 | + yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull | ||
| 216 | + request contains changes that will affect the `node` binary. This is because | ||
| 217 | + GitHub Actions CI does not cover all the environments supported by Node.js. | ||
| 218 | 218 | ||
| 219 | 219 | <details> | |
| 220 | 220 | <summary>Changes that affect the `node` binary</summary> | |
@@ -295,7 +295,7 @@ in the form: | |||
| 295 | 295 | To specify the branch this way, `refs/heads/BRANCH` is used | |
| 296 | 296 | (e.g. for `master` -> `refs/heads/master`). | |
| 297 | 297 | For pull requests, it will look like `refs/pull/PR_NUMBER/head` | |
| 298 | - (e.g. for PR#42 -> `refs/pull/42/head`). | ||
| 298 | + (e.g. for pull request #42 -> `refs/pull/42/head`). | ||
| 299 | 299 | * `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased | |
| 300 | 300 | onto master. This can especially be important for pull requests that have been | |
| 301 | 301 | open a while. | |
0 commit comments