Commit fdfcf68
http: destructure primordials in lib/_http_server.js
PR-URL: #30315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>1 parent a621ab8 commit fdfcf68
1 file changed
Lines changed: 12 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -21,7 +21,12 @@ | |||
| 21 | 21 | ||
| 22 | 22 | 'use strict'; | |
| 23 | 23 | ||
| 24 | - const { Object } = primordials; | ||
| 24 | + const { | ||
| 25 | + Object: { | ||
| 26 | + setPrototypeOf: ObjectSetPrototypeOf, | ||
| 27 | + keys: ObjectKeys, | ||
| 28 | + } | ||
| 29 | + } = primordials; | ||
| 25 | 30 | ||
| 26 | 31 | const net = require('net'); | |
| 27 | 32 | const assert = require('internal/assert'); | |
@@ -165,8 +170,8 @@ function ServerResponse(req) { | |||
| 165 | 170 | }; | |
| 166 | 171 | } | |
| 167 | 172 | } | |
| 168 | - Object.setPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype); | ||
| 169 | - Object.setPrototypeOf(ServerResponse, OutgoingMessage); | ||
| 173 | + ObjectSetPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype); | ||
| 174 | + ObjectSetPrototypeOf(ServerResponse, OutgoingMessage); | ||
| 170 | 175 | ||
| 171 | 176 | ServerResponse.prototype._finish = function _finish() { | |
| 172 | 177 | DTRACE_HTTP_SERVER_RESPONSE(this.connection); | |
@@ -258,8 +263,8 @@ function writeHead(statusCode, reason, obj) { | |||
| 258 | 263 | // Slow-case: when progressive API and header fields are passed. | |
| 259 | 264 | let k; | |
| 260 | 265 | if (obj) { | |
| 261 | - const keys = Object.keys(obj); | ||
| 262 | - for (let i = 0; i < keys.length; i++) { | ||
| 266 | + const keys = ObjectKeys(obj); | ||
| 267 | + for (var i = 0; i < keys.length; i++) { | ||
| 263 | 268 | k = keys[i]; | |
| 264 | 269 | if (k) this.setHeader(k, obj[k]); | |
| 265 | 270 | } | |
@@ -341,8 +346,8 @@ function Server(options, requestListener) { | |||
| 341 | 346 | this.maxHeadersCount = null; | |
| 342 | 347 | this.headersTimeout = 40 * 1000; // 40 seconds | |
| 343 | 348 | } | |
| 344 | - Object.setPrototypeOf(Server.prototype, net.Server.prototype); | ||
| 345 | - Object.setPrototypeOf(Server, net.Server); | ||
| 349 | + ObjectSetPrototypeOf(Server.prototype, net.Server.prototype); | ||
| 350 | + ObjectSetPrototypeOf(Server, net.Server); | ||
| 346 | 351 | ||
| 347 | 352 | ||
| 348 | 353 | Server.prototype.setTimeout = function setTimeout(msecs, callback) { | |
0 commit comments