lib: do not modify prototype deprecated asyncResource (encore) · nodejs/node@fe7176d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fe7176d

Browse filesBrowse the repository at this point in the historyBrowse files

slagiewka

authored and

targos

committed

lib: do not modify prototype deprecated asyncResource (encore)

Previous attempt has missed one argument (`useEmitSync`), therefore it effectively did not work as intended. This change sets `useEmitSync` to `false` which is equivalent to previous behaviour of `undefined` and sets `modifyPrototype` to `false` as expected. PR-URL: #59518 Refs: #58218 Refs: #59195 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent 4e02ea1 commit fe7176d
Copy full SHA for fe7176d

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • async_hooks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/async_hooks.js‎

Copy file name to clipboardExpand all lines: lib/async_hooks.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -262,10 +262,10 @@ class AsyncResource {
262	262	enumerable: true,
263	263	get: deprecate(function() {
264	264	return self;
265		- }, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false),
	265	+ }, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false, false),
266	266	set: deprecate(function(val) {
267	267	self = val;
268		- }, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false),
	268	+ }, 'The asyncResource property on bound functions is deprecated', 'DEP0172', false, false),
269	269	},
270	270	});
271	271	return bound;

0 commit comments

Comments

0 (0)