FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: make process.binding('util') return only type checkers · nodejs/node@fe73e4d · GitHub

/ node Public

Commit fe73e4d

Browse files
addaleax
committed
lib: make process.binding('util') return only type checkers
Ref: #37485 (review) Ref: #37787 PR-URL: #37819 Refs: #37787 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
1 parent 924238d commit fe73e4d

4 files changed

Lines changed: 74 additions & 0 deletions

File tree

‎lib/internal/bootstrap/loaders.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@ const runtimeDeprecatedList = new SafeSet([
113113
'v8',
114114
]);
115115

116+
const legacyWrapperList = new SafeSet([
117+
'util',
118+
]);
119+
116120
// Set up process.binding() and process._linkedBinding().
117121
{
118122
const bindingObj = ObjectCreate(null);
@@ -129,6 +133,9 @@ const runtimeDeprecatedList = new SafeSet([
129133
'DeprecationWarning',
130134
'DEP0111');
131135
}
136+
if (legacyWrapperList.has(module)) {
137+
return nativeModuleRequire('internal/legacy/processbinding')[module]();
138+
}
132139
return internalBinding(module);
133140
}
134141
// eslint-disable-next-line no-restricted-syntax

‎lib/internal/legacy/processbinding.js‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
'use strict';
2+
const {
3+
ArrayPrototypeFilter,
4+
ArrayPrototypeIncludes,
5+
ObjectFromEntries,
6+
ObjectEntries,
7+
SafeArrayIterator,
8+
} = primordials;
9+
const { types } = require('util');
10+
11+
module.exports = {
12+
util() {
13+
return ObjectFromEntries(new SafeArrayIterator(ArrayPrototypeFilter(
14+
ObjectEntries(types),
15+
({ 0: key }) => {
16+
return ArrayPrototypeIncludes([
17+
'isArrayBuffer',
18+
'isArrayBufferView',
19+
'isAsyncFunction',
20+
'isDataView',
21+
'isDate',
22+
'isExternal',
23+
'isMap',
24+
'isMapIterator',
25+
'isNativeError',
26+
'isPromise',
27+
'isRegExp',
28+
'isSet',
29+
'isSetIterator',
30+
'isTypedArray',
31+
'isUint8Array',
32+
'isAnyArrayBuffer',
33+
], key);
34+
})));
35+
}
36+
};

‎node.gyp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@
168168
'lib/internal/idna.js',
169169
'lib/internal/inspector_async_hook.js',
170170
'lib/internal/js_stream_socket.js',
171+
'lib/internal/legacy/processbinding.js',
171172
'lib/internal/linkedlist.js',
172173
'lib/internal/main/check_syntax.js',
173174
'lib/internal/main/eval_string.js',

‎test/parallel/test-process-binding-util.js‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
'use strict';
2+
require('../common');
3+
const assert = require('assert');
4+
const util = require('util');
5+
6+
const utilBinding = process.binding('util');
7+
assert.deepStrictEqual(
8+
Object.keys(utilBinding).sort(),
9+
[
10+
'isAnyArrayBuffer',
11+
'isArrayBuffer',
12+
'isArrayBufferView',
13+
'isAsyncFunction',
14+
'isDataView',
15+
'isDate',
16+
'isExternal',
17+
'isMap',
18+
'isMapIterator',
19+
'isNativeError',
20+
'isPromise',
21+
'isRegExp',
22+
'isSet',
23+
'isSetIterator',
24+
'isTypedArray',
25+
'isUint8Array',
26+
]);
27+
28+
for (const k of Object.keys(utilBinding)) {
29+
assert.strictEqual(utilBinding[k], util.types[k]);
30+
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL