Commit ff212f4
test: increase coverage for diagnostics_channel
1. test subscribe with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L27
2. test create channel with invalid args
https://coverage.nodejs.org/coverage-21f2e8859dfbf09f/lib/diagnostics_channel.js.html#L98
PR-URL: #36602
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>1 parent dcba374 commit ff212f4
2 files changed
Lines changed: 10 additions & 0 deletions
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,3 +37,7 @@ channel.publish(input); | |||
| 37 | 37 | // Should not publish after subscriber is unsubscribed | |
| 38 | 38 | channel.unsubscribe(subscriber); | |
| 39 | 39 | assert.ok(!channel.hasSubscribers); | |
| 40 | + | ||
| 41 | + assert.throws(() => { | ||
| 42 | + channel.subscribe(null); | ||
| 43 | + }, { code: 'ERR_INVALID_ARG_TYPE' }); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,3 +20,9 @@ channel.subscribe(common.mustCall((message, name) => { | |||
| 20 | 20 | })); | |
| 21 | 21 | ||
| 22 | 22 | channel.publish(input); | |
| 23 | + | ||
| 24 | + { | ||
| 25 | + assert.throws(() => { | ||
| 26 | + dc.channel(null); | ||
| 27 | + }, /ERR_INVALID_ARG_TYPE/); | ||
| 28 | + } | ||
0 commit comments