src: add not-weak DCHECK to PersistentToLocal::Strong · nodejs/node@ff7cc8f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ff7cc8f

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

richardlau

committed

src: add not-weak DCHECK to PersistentToLocal::Strong

Refs: #38821 (comment) PR-URL: #38875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent 2c28e00 commit ff7cc8f
Copy full SHA for ff7cc8f

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • util.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -760,6 +760,7 @@ class PersistentToLocal {
760	760	template <class TypeName>
761	761	static inline v8::Local<TypeName> Strong(
762	762	const v8::PersistentBase<TypeName>& persistent) {
	763	+ DCHECK(!persistent.IsWeak());
763	764	return *reinterpret_cast<v8::Local<TypeName>*>(
764	765	const_cast<v8::PersistentBase<TypeName>*>(&persistent));
765	766	}

0 commit comments

Comments

0 (0)