Commit ff7f28c
test: remove 3rd argument from assert.strictEqual
If there is an AssertionError, the string literal is printed and not the
value of `r`. For debugging purposes, it is good to know if `r` is false
or null or something else.
PR-URL: #19707
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent c8fa8f1 commit ff7f28c
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,7 +33,8 @@ const server = http.Server(common.mustCall(function(req, res) { | |||
| 33 | 33 | res.end(); | |
| 34 | 34 | ||
| 35 | 35 | const r = res.write('This should raise an error.'); | |
| 36 | - assert.strictEqual(r, true, 'write after end should return true'); | ||
| 36 | + // write after end should return true | ||
| 37 | + assert.strictEqual(r, true); | ||
| 37 | 38 | })); | |
| 38 | 39 | ||
| 39 | 40 | server.listen(0, function() { | |
0 commit comments