Commit ffe3040
lib: adding perf notes js_stream_socket.js
Leaving var in place of let for performance optimization
in short loops in hot paths. Added comments explaining why.
PR-URL: #30415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent 97e6273 commit ffe3040
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -157,6 +157,7 @@ class JSStreamSocket extends Socket { | |||
| 157 | 157 | let pending = bufs.length; | |
| 158 | 158 | ||
| 159 | 159 | this.stream.cork(); | |
| 160 | + // Use `var` over `let` for performance optimization. | ||
| 160 | 161 | for (var i = 0; i < bufs.length; ++i) | |
| 161 | 162 | this.stream.write(bufs[i], done); | |
| 162 | 163 | this.stream.uncork(); | |
0 commit comments