FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: ensure assertions are reached on more tests · nodejs/node@ffebf8e · GitHub

test: ensure assertions are reached on more tests · nodejs/node@ffebf8e · GitHub
Skip to content

Navigation Menu

Sign in
Sign in
Sign up

Commit ffebf8e

Browse files
aduh95
authored and
RafaelGSS
committed
test: ensure assertions are reached on more tests
PR-URL: #60726 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 2409839 commit ffebf8e

82 files changed

Lines changed: 853 additions & 956 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎test/eslint.config_partial.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export default [
194194
].join(',')}}/**/*.{js,mjs,cjs}`,
195195
`test/parallel/test-{${
196196
// 0x61 is code for 'a', this generates a string enumerating latin letters: 'a*,b*,…'
197-
Array.from({ length: 4 }, (_, i) => String.fromCharCode(0x61 + i, 42)).join(',')
197+
Array.from({ length: 7 }, (_, i) => String.fromCharCode(0x61 + i, 42)).join(',')
198198
},http-*,http2-*,${
199199
// 0x61 is code for 'a', this generates a string enumerating latin letters: 'z*,y*,…'
200200
Array.from({ length: 5 }, (_, i) => String.fromCharCode(0x61 + 25 - i, 42)).join(',')

‎test/parallel/test-error-format-list.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
'use strict';
33

44
const common = require('../common');
5-
const { strictEqual } = require('node:assert');
5+
const assert = require('node:assert');
66
const { formatList } = require('internal/errors');
77

88
if (!common.hasIntl) common.skip('missing Intl');
@@ -14,7 +14,7 @@ if (!common.hasIntl) common.skip('missing Intl');
1414
const input = ['apple', 'banana', 'orange', 'pear'];
1515
for (let i = 0; i < input.length; i++) {
1616
const slicedInput = input.slice(0, i);
17-
strictEqual(formatList(slicedInput), and.format(slicedInput));
18-
strictEqual(formatList(slicedInput, 'or'), or.format(slicedInput));
17+
assert.strictEqual(formatList(slicedInput), and.format(slicedInput));
18+
assert.strictEqual(formatList(slicedInput, 'or'), or.format(slicedInput));
1919
}
2020
}

‎test/parallel/test-error-reporting.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const fixtures = require('../common/fixtures');
2828
function errExec(script, option, callback) {
2929
callback = typeof option === 'function' ? option : callback;
3030
option = typeof option === 'string' ? option : '';
31-
return exec(...common.escapePOSIXShell`"${process.execPath}" ${option} "${fixtures.path(script)}"`, (err, stdout, stderr) => {
31+
return exec(...common.escapePOSIXShell`"${process.execPath}" ${option} "${fixtures.path(script)}"`, common.mustCall((err, stdout, stderr) => {
3232
// There was some error
3333
assert.ok(err);
3434

@@ -37,7 +37,7 @@ function errExec(script, option, callback) {
3737

3838
// Proxy the args for more tests.
3939
callback(err, stdout, stderr);
40-
});
40+
}));
4141
}
4242

4343
const syntaxErrorMessage = /\bSyntaxError\b/;

‎test/parallel/test-error-value-type-detection.mjs‎

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,211 +1,211 @@
11
// Flags: --expose-internals
22

33
import '../common/index.mjs';
4-
import { strictEqual } from 'node:assert';
4+
import assert from 'node:assert';
55
import errorsModule from 'internal/errors';
66

77

88
const { determineSpecificType } = errorsModule;
99

10-
strictEqual(
10+
assert.strictEqual(
1111
determineSpecificType(1n),
1212
'type bigint (1n)',
1313
);
1414

15-
strictEqual(
15+
assert.strictEqual(
1616
determineSpecificType(true),
1717
'type boolean (true)',
1818
);
19-
strictEqual(
19+
assert.strictEqual(
2020
determineSpecificType(false),
2121
'type boolean (false)',
2222
);
2323

24-
strictEqual(
24+
assert.strictEqual(
2525
determineSpecificType(2),
2626
'type number (2)',
2727
);
2828

29-
strictEqual(
29+
assert.strictEqual(
3030
determineSpecificType(NaN),
3131
'type number (NaN)',
3232
);
3333

34-
strictEqual(
34+
assert.strictEqual(
3535
determineSpecificType(Infinity),
3636
'type number (Infinity)',
3737
);
3838

39-
strictEqual(
39+
assert.strictEqual(
4040
determineSpecificType({ __proto__: null }),
4141
'[Object: null prototype] {}',
4242
);
4343

44-
strictEqual(
44+
assert.strictEqual(
4545
determineSpecificType(''),
4646
"type string ('')",
4747
);
4848

49-
strictEqual(
49+
assert.strictEqual(
5050
determineSpecificType(''),
5151
"type string ('')",
5252
);
53-
strictEqual(
53+
assert.strictEqual(
5454
determineSpecificType("''"),
5555
"type string (\"''\")",
5656
);
57-
strictEqual(
57+
assert.strictEqual(
5858
determineSpecificType('Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor'),
5959
"type string ('Lorem ipsum dolor sit ame...')",
6060
);
61-
strictEqual(
61+
assert.strictEqual(
6262
determineSpecificType("Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor'"),
6363
"type string ('Lorem ipsum dolor sit ame...')",
6464
);
65-
strictEqual(
65+
assert.strictEqual(
6666
determineSpecificType("Lorem' ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor"),
6767
"type string (\"Lorem' ipsum dolor sit am...\")",
6868
);
6969

70-
strictEqual(
70+
assert.strictEqual(
7171
determineSpecificType(Symbol('foo')),
7272
'type symbol (Symbol(foo))',
7373
);
7474

75-
strictEqual(
75+
assert.strictEqual(
7676
determineSpecificType(function foo() {}),
7777
'function foo',
7878
);
7979

8080
const implicitlyNamed = function() {}; // eslint-disable-line func-style
81-
strictEqual(
81+
assert.strictEqual(
8282
determineSpecificType(implicitlyNamed),
8383
'function implicitlyNamed',
8484
);
85-
strictEqual(
85+
assert.strictEqual(
8686
determineSpecificType(() => {}),
8787
'function ',
8888
);
8989
function noName() {}
9090
delete noName.name;
91-
strictEqual(
91+
assert.strictEqual(
9292
noName.name,
9393
'',
9494
);
95-
strictEqual(
95+
assert.strictEqual(
9696
determineSpecificType(noName),
9797
'function ',
9898
);
9999

100100
function * generatorFn() {}
101-
strictEqual(
101+
assert.strictEqual(
102102
determineSpecificType(generatorFn),
103103
'function generatorFn',
104104
);
105105

106106
async function asyncFn() {}
107-
strictEqual(
107+
assert.strictEqual(
108108
determineSpecificType(asyncFn),
109109
'function asyncFn',
110110
);
111111

112-
strictEqual(
112+
assert.strictEqual(
113113
determineSpecificType(null),
114114
'null',
115115
);
116116

117-
strictEqual(
117+
assert.strictEqual(
118118
determineSpecificType(undefined),
119119
'undefined',
120120
);
121121

122-
strictEqual(
122+
assert.strictEqual(
123123
determineSpecificType([]),
124124
'an instance of Array',
125125
);
126126

127-
strictEqual(
127+
assert.strictEqual(
128128
determineSpecificType(new Array()),
129129
'an instance of Array',
130130
);
131-
strictEqual(
131+
assert.strictEqual(
132132
determineSpecificType(new BigInt64Array()),
133133
'an instance of BigInt64Array',
134134
);
135-
strictEqual(
135+
assert.strictEqual(
136136
determineSpecificType(new BigUint64Array()),
137137
'an instance of BigUint64Array',
138138
);
139-
strictEqual(
139+
assert.strictEqual(
140140
determineSpecificType(new Int8Array()),
141141
'an instance of Int8Array',
142142
);
143-
strictEqual(
143+
assert.strictEqual(
144144
determineSpecificType(new Int16Array()),
145145
'an instance of Int16Array',
146146
);
147-
strictEqual(
147+
assert.strictEqual(
148148
determineSpecificType(new Int32Array()),
149149
'an instance of Int32Array',
150150
);
151-
strictEqual(
151+
assert.strictEqual(
152152
determineSpecificType(new Float32Array()),
153153
'an instance of Float32Array',
154154
);
155-
strictEqual(
155+
assert.strictEqual(
156156
determineSpecificType(new Float64Array()),
157157
'an instance of Float64Array',
158158
);
159-
strictEqual(
159+
assert.strictEqual(
160160
determineSpecificType(new Uint8Array()),
161161
'an instance of Uint8Array',
162162
);
163-
strictEqual(
163+
assert.strictEqual(
164164
determineSpecificType(new Uint8ClampedArray()),
165165
'an instance of Uint8ClampedArray',
166166
);
167-
strictEqual(
167+
assert.strictEqual(
168168
determineSpecificType(new Uint16Array()),
169169
'an instance of Uint16Array',
170170
);
171-
strictEqual(
171+
assert.strictEqual(
172172
determineSpecificType(new Uint32Array()),
173173
'an instance of Uint32Array',
174174
);
175175

176-
strictEqual(
176+
assert.strictEqual(
177177
determineSpecificType(new Date()),
178178
'an instance of Date',
179179
);
180180

181-
strictEqual(
181+
assert.strictEqual(
182182
determineSpecificType(new Map()),
183183
'an instance of Map',
184184
);
185-
strictEqual(
185+
assert.strictEqual(
186186
determineSpecificType(new WeakMap()),
187187
'an instance of WeakMap',
188188
);
189189

190-
strictEqual(
190+
assert.strictEqual(
191191
determineSpecificType({}),
192192
'an instance of Object',
193193
);
194-
strictEqual(
194+
assert.strictEqual(
195195
determineSpecificType(new Object()),
196196
'an instance of Object',
197197
);
198198

199-
strictEqual(
199+
assert.strictEqual(
200200
determineSpecificType(Promise.resolve('foo')),
201201
'an instance of Promise',
202202
);
203203

204-
strictEqual(
204+
assert.strictEqual(
205205
determineSpecificType(new Set()),
206206
'an instance of Set',
207207
);
208-
strictEqual(
208+
assert.strictEqual(
209209
determineSpecificType(new WeakSet()),
210210
'an instance of WeakSet',
211211
);

‎test/parallel/test-errors-aborterror.js‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,27 @@
22
'use strict';
33

44
require('../common');
5-
const {
6-
strictEqual,
7-
throws,
8-
} = require('assert');
5+
const assert = require('assert');
96
const { AbortError } = require('internal/errors');
107

118
{
129
const err = new AbortError();
13-
strictEqual(err.message, 'The operation was aborted');
14-
strictEqual(err.cause, undefined);
10+
assert.strictEqual(err.message, 'The operation was aborted');
11+
assert.strictEqual(err.cause, undefined);
1512
}
1613

1714
{
1815
const cause = new Error('boom');
1916
const err = new AbortError('bang', { cause });
20-
strictEqual(err.message, 'bang');
21-
strictEqual(err.cause, cause);
17+
assert.strictEqual(err.message, 'bang');
18+
assert.strictEqual(err.cause, cause);
2219
}
2320

2421
{
25-
throws(() => new AbortError('', false), {
22+
assert.throws(() => new AbortError('', false), {
2623
code: 'ERR_INVALID_ARG_TYPE'
2724
});
28-
throws(() => new AbortError('', ''), {
25+
assert.throws(() => new AbortError('', ''), {
2926
code: 'ERR_INVALID_ARG_TYPE'
3027
});
3128
}

‎test/parallel/test-errors-hide-stack-frames.js‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Flags: --expose-internals
22
'use strict';
33

4-
require('../common');
4+
const common = require('../common');
55
const { hideStackFrames, codes } = require('internal/errors');
66
const { validateInteger } = require('internal/validators');
77
const assert = require('assert');
@@ -209,19 +209,15 @@ const assert = require('assert');
209209

210210
{
211211
// Binding passes the value of this to the wrapped function.
212-
let called = false;
213212
function a() {
214213
b.bind({ key: 'value' })();
215214
}
216215

217-
const b = hideStackFrames(function b() {
216+
const b = hideStackFrames(common.mustCall(function b() {
218217
assert.strictEqual(this.key, 'value');
219-
called = true;
220-
});
218+
}));
221219

222220
a();
223-
224-
assert.strictEqual(called, true);
225221
}
226222

227223
{
@@ -231,10 +227,10 @@ const assert = require('assert');
231227
b.withoutStackTrace.bind({ key: 'value' })();
232228
}
233229

234-
const b = hideStackFrames(function b() {
230+
const b = hideStackFrames(common.mustCall(function b() {
235231
assert.strictEqual(this.key, 'value');
236232
called = true;
237-
});
233+
}));
238234

239235
a();
240236

0 commit comments

Comments
 (0)

Footer

© 2026 GitHub, Inc.
Back | FazBrowse Home | New Git URL