stream: change stream to use index instead of `for...of` · nodejs/node@fffc300 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fffc300

Browse filesBrowse the repository at this point in the historyBrowse files

HBSPS

authored and

RafaelGSS

committed

stream: change stream to use index instead of for...of

PR-URL: #54474 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent b584356 commit fffc300
Copy full SHA for fffc300

1 file changed

+6-2Lines changed: 6 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • stream.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/stream.js‎

Copy file name to clipboardExpand all lines: lib/stream.js

+6-2Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -61,7 +61,9 @@ Stream.isReadable = utils.isReadable;
61	61	Stream.isWritable = utils.isWritable;
62	62
63	63	Stream.Readable = require('internal/streams/readable');
64		- for (const key of ObjectKeys(streamReturningOperators)) {
	64	+ const streamKeys = ObjectKeys(streamReturningOperators);
	65	+ for (let i = 0; i < streamKeys.length; i++) {
	66	+ const key = streamKeys[i];
65	67	const op = streamReturningOperators[key];
66	68	function fn(...args) {
67	69	if (new.target) {
@@ -79,7 +81,9 @@ for (const key of ObjectKeys(streamReturningOperators)) {
79	81	writable: true,
80	82	});
81	83	}
82		- for (const key of ObjectKeys(promiseReturningOperators)) {
	84	+ const promiseKeys = ObjectKeys(promiseReturningOperators);
	85	+ for (let i = 0; i < promiseKeys.length; i++) {
	86	+ const key = promiseKeys[i];
83	87	const op = promiseReturningOperators[key];
84	88	function fn(...args) {
85	89	if (new.target) {

0 commit comments

Comments

0 (0)