FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: remove redundant 'use strict' from test files (#64) · nodejs/node-api-cts@9aa4c88 · GitHub

/ node-api-cts Public

Commit 9aa4c88

Browse files
hexbinoct
and
claude
authored
chore: remove redundant 'use strict' from test files (#64)
Test files under tests/ are evaluated as ES modules, which are always in strict mode, so the directive carried over from the upstream CommonJS sources has no effect. Records the rule in the porting instructions as well, so it does not come back with the next port. Closes #41 Signed-off-by: hexbinoct <abubakarm@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 441645c commit 9aa4c88

38 files changed

Lines changed: 1 addition & 55 deletions

File tree

‎.github/copilot-instructions.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Node-API Conformance Test Suite: A pure ECMAScript test suite for Node-API imple
66

77
## General Principles
88
- **Keep it minimal**: Avoid unnecessary dependencies, configuration, or complexity
9-
- **Pure ECMAScript tests**: To lower the barrier for implementors to run the tests, all tests are written as single files of pure ECMAScript, with no import / export statements and no use of Node.js runtime APIs outside of the language standard (such as `process`, `require`, `node:*` modules).
9+
- **Pure ECMAScript tests**: To lower the barrier for implementors to run the tests, all tests are written as single files of pure ECMAScript, with no import / export statements and no use of Node.js runtime APIs outside of the language standard (such as `process`, `require`, `node:*` modules). Test files are evaluated as ES modules, which are always in strict mode, so drop the `'use strict'` directive when porting a file that carries one.
1010
- **TypeScript tooling**: The tooling around the tests are written in TypeScript and expects to be ran in a Node.js compatible runtime with type-stripping enabled. Never rely on `ts-node`, `node --loader ts-node/esm`, or `--experimental-strip-types`; use only stable, built-in Node.js capabilities.
1111
- **Implementor Flexibility**: Native code building and loading is delegated to implementors, with the test-suite providing defaults that work for Node.js.
1212
- **Extra convenience**: Extra (generated) code is provided to make it easier for implementors to load and run tests, such as extra package exports exposing test functions that implementors can integrate with their preferred test frameworks.

‎tests/harness/features.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
assert.ok(
42
typeof experimentalFeatures === 'object' && experimentalFeatures !== null,
53
'Expected a global experimentalFeatures object',

‎tests/harness/load-addon.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
if (typeof loadAddon !== 'function') {
42
throw new Error('Expected a global loadAddon function');
53
}

‎tests/harness/napi-version.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
// napiVersion is a positive integer
42
if (typeof napiVersion !== 'number' || napiVersion < 1 || !Number.isInteger(napiVersion)) {
53
throw new Error('Expected a global napiVersion that is a positive integer');

‎tests/harness/skip-test.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict';
2-
31
// skipTest is a function
42
if (typeof skipTest !== 'function') {
53
throw new Error('Expected a global skipTest function');

‎tests/js-native-api/3_callbacks/test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
'use strict';
21
const addon = loadAddon('3_callbacks');
32

43
addon.RunCallback(mustCall((msg) => {

‎tests/js-native-api/4_object_factory/test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
'use strict';
21
const addon = loadAddon('4_object_factory');
32

43
const obj1 = addon('hello');

‎tests/js-native-api/5_function_factory/test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
'use strict';
21
const addon = loadAddon('5_function_factory');
32

43
const fn = addon();

‎tests/js-native-api/7_factory_wrap/test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
'use strict';
21
const test = loadAddon('7_factory_wrap');
32

43
assert.strictEqual(test.finalizeCount, 0);

‎tests/js-native-api/8_passing_wrapped/test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
'use strict';
21
const addon = loadAddon('8_passing_wrapped');
32

43
let obj1 = addon.createObject(10);

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL