FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(git-node): handle single-line commit messages by aduh95 · Pull Request #1059 · nodejs/node-core-utils · GitHub

/ node-core-utils Public

fix(git-node): handle single-line commit messages - #1059

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:fix-single-line-commit
Apr 14, 2026
ConversationCommits (3)ChecksFiles changed
Merged

fix(git-node): handle single-line commit messages#1059
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:fix-single-line-commit

Conversation

aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Fixes: #1058

codecov Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (a9048c8) to head (d941035).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/landing_session.js 70.45% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   80.56%   71.74%   -8.83%     
==========================================
  Files          39       41       +2     
  Lines        4847     5878    +1031     
==========================================
+ Hits         3905     4217     +312     
- Misses        942     1661     +719

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 requested a review from richardlau April 14, 2026 09:11

aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/node-core-utils the CQ is mostly broken without this, can I get some reviews?

aduh95 mentioned this pull request Apr 14, 2026
Merged
marco-ippolito approved these changes Apr 14, 2026
View reviewed changes

marco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

aduh95 merged commit f510b8a into nodejs:main Apr 14, 2026
11 of 13 checks passed
aduh95 deleted the fix-single-line-commit branch April 14, 2026 17:12
nodejs-github-bot mentioned this pull request Apr 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

marco-ippolito marco-ippolito approved these changes
richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooling is confused by commits with title only

2 participants

Back | FazBrowse Home | New Git URL