FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add metadata JSON readiness output by panva · Pull Request #1113 · nodejs/node-core-utils · GitHub

/ node-core-utils Public

feat: add metadata JSON readiness output - #1113

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
panva:metadata-json-readiness
Jul 9, 2026
ConversationCommits (2)ChecksFiles changed
Merged

feat: add metadata JSON readiness output#1113
aduh95 merged 2 commits into
nodejs:mainfrom
panva:metadata-json-readiness

Conversation

panva commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This adds structured readiness output to git node metadata --json so automation can consume PR landability checks without matching human-readable CLI output.

The JSON output includes:

  • ready
  • readiness
  • exitCode
  • metadata
  • reasonCodes
  • reasons

It also adds stable reason codes from PRChecker for the existing readiness checks.

Exit Codes

git node metadata --json uses category-level exit codes:

  • 0: PR is ready
  • 20: PR is not ready for deferrable metadata reasons
  • 40: PR is not ready for a hard or mixed reason
  • 1: unexpected tool/runtime failure

20-29 are reserved for future deferrable metadata states, and 40-49 are reserved for future hard metadata failure states.

The current deferrable set is scoped to the lightweight commit-queue selector use case from nodejs/node#64343:

  • missing-approval
  • missing-tsc-approval
  • wait-time

codecov Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.45387% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.43%. Comparing base (9250fba) to head (733f3a8).

Files with missing lines Patch % Lines
lib/pr_checker.js 92.63% 12 Missing ⚠️
components/git/metadata.js 67.64% 11 Missing ⚠️
components/metadata.js 85.13% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   62.01%   62.43%   +0.42%     
==========================================
  Files          46       48       +2     
  Lines        7505     7882     +377     
==========================================
+ Hits         4654     4921     +267     
- Misses       2851     2961     +110

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

feat: add metadata JSON readiness output
d416c6a 
Expose stable PR readiness reason codes from PRChecker and add
git node metadata --json for machine-readable metadata readiness
results.

The JSON output includes readiness classification, reserved exit-code
categories, generated metadata, unique reason codes, and detailed
reasons.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva force-pushed the metadata-json-readiness branch from 7949e79 to d416c6a Compare July 8, 2026 12:51
panva changed the title tools: add metadata JSON readiness output feat: add metadata JSON readiness output Jul 8, 2026
panva mentioned this pull request Jul 8, 2026
Merged

aduh95 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The current deferrable set is scoped to […]:

  • missing-approval
  • missing-tsc-approval
  • wait-time

Can we change that to only capture wait time? E.g. missing TSC approval should be a hard error, no amount of time is going to help with that, and not erroring would be confusing IMO. Missing approval would mean that someone has added the CQ label on a 0-approval PR, again that seems like an error

panva commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@aduh95 makes sense, i'll update the utils and then the node PR

aduh95 approved these changes Jul 8, 2026
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, we might also want to add PENDING_CI as deferable, so we can clean up https://github.com/nodejs/node/blob/db7cc5b40018e685f9f409b382884f84dec71c65/tools/actions/commit-queue.sh#L42-L46

panva commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm not sold on pending ci. With how flaky ci can get i think noone should be adding cq to a PR with an in progress ci. As such the cleanup you speak of would be imho better suited to go in the other direction.

aduh95 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

That's fine by me. I think the idea is to get the CQ to notify you if the CI failed

aduh95 merged commit a22e127 into nodejs:main Jul 9, 2026
11 checks passed
nodejs-github-bot mentioned this pull request Jul 9, 2026
Merged
panva deleted the metadata-json-readiness branch July 9, 2026 10:49
aduh95 mentioned this pull request Aug 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL