feat(git-node): select security release PRs from affectedVersions - #1124
Merged
RafaelGSS merged 1 commit intoJul 23, 2026
Merged
feat(git-node): select security release PRs from affectedVersions#1124RafaelGSS merged 1 commit into
RafaelGSS merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`git node release --prepare --security` now selects the PRs to cherry-pick from the per-line `affectedVersions` mapping of each report and dependency, instead of scanning open PRs and filtering by label. - `--security` accepts the path to vulnerabilities.json directly (or the security-release repository root). - Reports and dependency updates are picked for the release line being prepared, resolving the owner/repo from the PR URL so both node-private and public node PRs are supported. - CVE-ID trailers are taken from the matching report. - Dependency updates now use the same `affectedVersions` schema as the reports, updating the generator and the `git node security` consumer. Removed the `--filterLabel` option and the open PR scan.
marco-ippolito
approved these changes
Jul 23, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 35.03185% with 102 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 61.81% 57.09% -4.73%
==========================================
Files 51 53 +2
Lines 9083 10150 +1067
==========================================
+ Hits 5615 5795 +180
- Misses 3468 4355 +887 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git node release --prepare --security previously scanned all open PRs in nodejs-private/node-private (capped at 20), filtered only by --filterLabel, with no notion of release line, and matched CVEs via the legacy prURL field.
Dependency updates were ignored, and --security=../vulnerabilities.json did not resolve because it expected the repository root.
This change drives the whole flow from each entry's affectedVersions mapping.