fix: dont write log file for completion commands - #7497
Merged
lukekarrys merged 1 commit intoMay 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Since npm completion is implemented by calling npm completion -- arg1 this will write a logfile for that command. I noticed this as I was trying to look through my logs for a recent command and found that it had been removed since I used enough tab completions to fill logs-max.
Copy link
Copy Markdown
Contributor
Author
|
Here's what a grep of my logs looked like previously: ❯ grep -r "argv" _logs/ _logs//2024-05-09T19_05_19_129Z-debug-0.log:8 verbose argv "completion" "--" "npm" "vi" _logs//2024-05-09T19_05_18_423Z-debug-0.log:8 verbose argv "completion" "--" "" _logs//2024-05-09T19_05_20_636Z-debug-0.log:8 verbose argv "completion" "--" "npm" "view" "" _logs//2024-05-09T19_05_18_304Z-debug-0.log:8 verbose argv "completion" |
Sorry, something went wrong.
wraithgar
reviewed
May 9, 2024
Comment thread
lib/utils/log-file.js
wraithgar
approved these changes
May 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since npm completion is implemented by calling npm completion -- arg1
this will write a logfile for that command. I noticed this as I was trying
to look through my logs for a recent command and found that it had been removed
since I used enough tab completions to fill logs-max.