FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: remove stale comment by jsoref · Pull Request #8598 · npm/cli · GitHub

/ cli Public

chore: remove stale comment - #8598

Merged
owlstronaut merged 1 commit into
npm:latestfrom
jsoref:remove-stale-comment
Sep 26, 2025
Merged

chore: remove stale comment#8598
owlstronaut merged 1 commit into
npm:latestfrom
jsoref:remove-stale-comment

Conversation

jsoref commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Remove stale comment

References

This comment was originally written like this:

// only update the notification timeout if we actually finished checking
module.exports = async npm => {
const notification = await updateNotifier(npm)
// intentional. do not await this. it's a best-effort update.
updateTimeout(npm)
npm.updateNotification = notification

The code that updates the timeout is no longer anywhere close to this comment:

// intentional. do not await this. it's a best-effort update. if this
// fails, it's ok. might be using /dev/null as the cache or something weird
// like that.
writeFile(lastCheckedFile(npm), '').catch(() => {})

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref requested a review from a team as a code owner September 26, 2025 18:29
owlstronaut merged commit bb4b739 into npm:latest Sep 26, 2025
20 checks passed
github-actions Bot mentioned this pull request Sep 25, 2025
jsoref deleted the remove-stale-comment branch September 26, 2025 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL