Name shared path parameter helper types once, hashing cross-path coll… · oapi-codegen/oapi-codegen@bd52535 · GitHub

oapi-codegen / oapi-codegen Public

• Notifications You must be signed in to change notification settings
• Fork 1.1k
• Star 8.5k

• Code
• Issues 250
• Pull requests 68
• Discussions
• Actions
• Projects
• Security and quality 4
• Insights

Additional navigation options

Commit bd52535

Browse filesBrowse the repository at this point in the historyBrowse files

mromaszewicz

and

claude

authored

Name shared path parameter helper types once, hashing cross-path collisions (#2476)

* Revert "Generate shared path-level parameter helper types once (#2466)" This reverts commit a07731d. * Name shared path parameter helper types once, hashing cross-path collisions Closes: #2090 A parameter declared at the path-item level is inherited by every method on the path. Its hoisted helper types -- the members of an inline anyOf/oneOf and similar -- were named from the parameter alone and declared once per operation, so a path with more than one method redeclared them ("Id0 redeclared in this block"). The same bare names also collided across different paths that reuse the same parameter, which is the common REST case of an {id} shared by sibling paths. Resolve path-item-level parameters in a single pre-pass (resolveSharedParameters): describe each scope's shared parameters once, count how many scopes hoist a helper type under each name, and emit each scope's helper types once for its path item rather than once per operation. A name produced by two or more scopes is disambiguated by prefixing that scope's parameters with a short, stable FNV hash of the scope, extended to the full hash only if two scopes' short hashes clash. A parameter that does not collide keeps its historical undecorated name, so existing generated code is unaffected -- the only outputs that change are specs that previously failed to compile. Applied uniformly to regular paths, webhooks, and callbacks, which share the one global Go type namespace. Disambiguated types carry a doc comment explaining the hash prefix and pointing back to the source path. Adds internal/test/parameters/shared_collision covering a shared anyOf parameter across multiple methods on a path (bare, emitted once), the same parameter reused across sibling paths (hash-disambiguated), and a non-colliding single-method parameter (unchanged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 parent ce2e068 commit bd52535
Copy full SHA for bd52535

17 files changed

+1,784-1,965Lines changed: 1784 additions & 1965 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• internal/test
  • parameters
    • shared_anyof
      • doc.go
      • shared_anyof.gen.go
      • shared_anyof_test.go
      • spec.yaml
    • shared_collision
      • config.yaml
      • doc.go
      • shared_collision.gen.go
      • shared_collision_test.go
      • spec.yaml
  • spec_validation
    • spec_validation_test.go
    • testdata
      • shared_path_param_type_collision.yaml
      • valid.yaml
• pkg/codegen
  • codegen.go
  • operations.go
  • schema.go
  • templates
    • param-types.tmpl
  • validate_spec.go

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎internal/test/parameters/shared_anyof/doc.go‎

Copy file name to clipboardExpand all lines: internal/test/parameters/shared_anyof/doc.go

-8Lines changed: 0 additions & 8 deletions

This file was deleted.

0 commit comments

Comments

0 (0)