Fixed bug, which was so obvious that I am wondering how none of the t… · og-python-scripts/GitPython@87ae425 · GitHub

1. og-python-scripts
2. GitPython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 87ae425

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Fixed bug, which was so obvious that I am wondering how none of the test ran into that, or at least triggered it

1 parent f631214 commit 87ae425
Copy full SHA for 87ae425

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects/submodule
  • base.py
  • root.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -905,7 +905,7 @@ def iter_items(cls, repo, parent_commit='HEAD'):
905	905	# try the index, maybe it was just added
906	906	try:
907	907	entry = index.entries[index.entry_key(p, 0)]
908		- sm = cls(repo, entry.binsha, entry.mode, entry.path)
	908	+ sm = Submodule(repo, entry.binsha, entry.mode, entry.path)
909	909	except KeyError:
910	910	raise InvalidGitRepositoryError("Gitmodule path %r did not exist in revision of parent commit %s" % (p, parent_commit))
911	911	# END handle keyerror

Collapse file

‎git/objects/submodule/root.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/root.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -109,7 +109,7 @@ def update(self, previous_commit=None, recursive=True, force_remove=False, init=
109	109
110	110
111	111	psms = self.list_items(repo, parent_commit=previous_commit)
112		- sms = self.list_items(self.module())
	112	+ sms = self.list_items(repo)
113	113	spsms = set(psms)
114	114	ssms = set(sms)
115	115

0 commit comments

Comments

0 (0)