FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: shutdown now clears hooks, evaluationContext and transactionContextPropagator as per spec 1.6.2 by jarebudev · Pull Request #1936 · open-feature/java-sdk · GitHub

/ java-sdk Public

fix: shutdown now clears hooks, evaluationContext and transactionContextPropagator as per spec 1.6.2 - #1936

Merged
beeme1mr merged 3 commits into
open-feature:mainfrom
jarebudev:1926_shutdown_doesnt_clear_hooks_or_provider_context
May 20, 2026
ConversationCommits (3)ChecksFiles changed
Merged

fix: shutdown now clears hooks, evaluationContext and transactionContextPropagator as per spec 1.6.2#1936
beeme1mr merged 3 commits into
open-feature:mainfrom
jarebudev:1926_shutdown_doesnt_clear_hooks_or_provider_context

Conversation

jarebudev commented May 7, 2026

Copy link
Copy Markdown
Contributor

This PR

Ensures that Spec 1.6.2 is implemented correctly. shutdown will now also clear the hooks, evaluationContext and transactionContextPropagator.

Related Issues

Fixes #1926

Notes

N/A

Follow-up Tasks

N/A

How to test

Unit test added to cover this change

fix: shutdown now clears hooks, evaluationContext and transactionCont…
d4dbb04 
…extPropagator as per spec 1.6.2

Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
jarebudev requested review from a team as code owners May 7, 2026 19:39
gemini-code-assist Bot reviewed May 7, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request updates the OpenFeatureAPI.shutdown() method to reset the API state, including hooks, evaluation context, and transaction context propagators, in accordance with specification 1.6.2. The corresponding test suite has been updated to verify these resets. Feedback was provided to improve the test's robustness by adding a hook before shutdown to ensure the clearing logic is properly verified and by using mocks for consistency.

Comment thread src/test/java/dev/openfeature/sdk/ShutdownBehaviorSpecTest.java

codecov Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (51754a5) to head (d4067d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1936      +/-   ##
============================================
+ Coverage     92.25%   93.27%   +1.01%     
- Complexity      653      656       +3     
============================================
  Files            59       59              
  Lines          1589     1592       +3     
  Branches        179      179              
============================================
+ Hits           1466     1485      +19     
+ Misses           76       62      -14     
+ Partials         47       45       -2
Flag Coverage Δ
unittests 93.27% <100.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

applied Gemini code review suggested change to verify that hooks are …
2583416 
…cleared

Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
use ImmutableContext.EMPTY. Added extra test assertions.
d4067d4 
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>

sonarqubecloud Bot commented May 12, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chrfwow approved these changes May 13, 2026
View reviewed changes

chrfwow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm. I don't understand where the license issue comes from

beeme1mr approved these changes May 20, 2026
View reviewed changes

beeme1mr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FYI, I've resolved the false positive licensing issue.

beeme1mr merged commit fb2181f into open-feature:main May 20, 2026
12 of 13 checks passed
openfeaturebot mentioned this pull request May 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

beeme1mr beeme1mr approved these changes
chrfwow chrfwow approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shutdown() doesn't clear hooks or evaluation context

3 participants

Back | FazBrowse Home | New Git URL