FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf: avoid Optional.ofNullable wrapping on hook.before() return value by tobias-ibounig-dt · Pull Request #1955 · open-feature/java-sdk · GitHub

/ java-sdk Public

perf: avoid Optional.ofNullable wrapping on hook.before() return value - #1955

Merged
toddbaert merged 2 commits into
open-feature:mainfrom
tobias-ibounig-dt:perf/pr-4-optional-ofnullable
Jun 8, 2026
ConversationCommits (2)ChecksFiles changed
Merged

perf: avoid Optional.ofNullable wrapping on hook.before() return value#1955
toddbaert merged 2 commits into
open-feature:mainfrom
tobias-ibounig-dt:perf/pr-4-optional-ofnullable

Conversation

tobias-ibounig-dt commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR

  • Replaces Optional.ofNullable(hook.before(...)).orElse(Optional.empty()) with a direct null check

Related Issues

None

Notes

The previous pattern wrapped the return value of hook.before() in Optional.ofNullable() to guard against null returns (which are non-standard but possible). This created up to two temporary Optional objects per hook call. The replacement assigns the return value directly and guards with an explicit != null check, which is semantically equivalent.

Allocation impact is negligible, but reduces on totalAllocatedInstances can be seen.

Metric main (baseline) PR 4 Delta
run:+totalAllocatedBytes 124,265,984 124,268,232 ~0 (noise)
run:+totalAllocatedInstances 2,723,316 2,700,508 −22,808 (−0.8%)

Follow-up Tasks

-More PRs with memory improvements

  • Update benchmark.txt after all are applied

tobias-ibounig-dt requested review from a team as code owners June 5, 2026 08:38
gemini-code-assist Bot reviewed Jun 5, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request simplifies the retrieval and validation of returnedEvalContext in HookSupport.java by directly assigning the result of hook.before and checking for null and presence. The reviewer suggested refactoring the code to use ifPresent instead of the isPresent() and get() pattern to make it more idiomatic and readable.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/dev/openfeature/sdk/HookSupport.java

toddbaert commented Jun 8, 2026

Copy link
Copy Markdown
Member

Hey - there's an issue with the codecov action (some keys are no longer available) which has been fixed on main; rebasing this PR should fix it. cc @chrfwow

This was referenced Jun 8, 2026
Merged
Merged
Merged
toddbaert force-pushed the perf/pr-4-optional-ofnullable branch from f156cbd to e7cb62e Compare June 8, 2026 13:25
tobias-ibounig-dt and others added 2 commits June 8, 2026 09:25
perf: avoid Optional.ofNullable wrapping on hook.before() return value
28d902c 
Signed-off-by: Tobias Ibounig <tobias.ibounig@dynatrace.com>
chore: suppress sonar S2789 on defensive null-check
65aeafa 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert force-pushed the perf/pr-4-optional-ofnullable branch from e7cb62e to 65aeafa Compare June 8, 2026 13:25

toddbaert commented Jun 8, 2026

Copy link
Copy Markdown
Member

Added a supression.

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

toddbaert enabled auto-merge (squash) June 8, 2026 13:26
toddbaert self-requested a review June 8, 2026 13:26

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (8fbf507) to head (65aeafa).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1955      +/-   ##
============================================
+ Coverage     92.26%   93.26%   +0.99%     
- Complexity      653      657       +4     
============================================
  Files            59       59              
  Lines          1591     1589       -2     
  Branches        179      179              
============================================
+ Hits           1468     1482      +14     
+ Misses           76       62      -14     
+ Partials         47       45       -2
Flag Coverage Δ
unittests 93.26% <100.00%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

toddbaert merged commit b611d55 into open-feature:main Jun 8, 2026
10 checks passed
openfeaturebot mentioned this pull request Jun 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chrfwow chrfwow approved these changes
toddbaert toddbaert approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL