Merge pull request #348 from mlauter/fix-347 · optionalg/bpython@fe7fa6c · GitHub

optionalg / bpython Public

forked from bpython/bpython

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit fe7fa6c

Browse filesBrowse the repository at this point in the historyBrowse files

thomasballinger

committed

Merge pull request bpython#348 from mlauter/fix-347

Fix bpython#347

2 parents b770323 + ce4ab58 commit fe7fa6c
Copy full SHA for fe7fa6c

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• bpython
  • autocomplete.py
  • test
    • test_autocomplete.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎bpython/autocomplete.py‎

Copy file name to clipboardExpand all lines: bpython/autocomplete.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -342,7 +342,7 @@ def safe_eval(expr, namespace):
342	342	try:
343	343	obj = eval(expr, namespace)
344	344	return obj
345		- except (NameError, AttributeError) as e:
	345	+ except (NameError, AttributeError, SyntaxError) as e:
346	346	# If debugging safe_eval, raise this!
347	347	# raise e
348	348	return SafeEvalFailed

Collapse file

‎bpython/test/test_autocomplete.py‎

Copy file name to clipboardExpand all lines: bpython/test/test_autocomplete.py

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -34,6 +34,12 @@ def test_cw(self):
34	34	self.assertEqual(self.repl.cw(), 'datetime')
35	35	"""
36	36
	37	+ class TestSafeEval(unittest.TestCase):
	38	+ def test_catches_syntax_error(self):
	39	+ try:
	40	+ autocomplete.safe_eval('1re',{})
	41	+ except:
	42	+ self.fail('safe_eval raises an error')
37	43
38	44	# make some fake files? Dependency inject? mock?
39	45	class TestFilenameCompletion(unittest.TestCase):

0 commit comments

Comments

0 (0)