FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing dudanov:main...pafernanr:main · dudanov/python-pyftms · GitHub

/ python-pyftms Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dudanov/python-pyftms
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: pafernanr/python-pyftms
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 11 files changed
  • 1 contributor

Commits on Aug 22, 2026

  1. fix: CrossTrainer 3-byte flags deserialization 

    CrossTrainerData uses 24-bit (3-octet) flags per FTMS spec (0x2ACE),
but base RealtimeData hardcoded 2-byte flags. Add ClassVar _flags_size
so subclasses can override. Fixes corrupted field parsing on cross
trainers.

Ref: #71
    pafernanr committed Aug 22, 2026
    Configuration menu
    Copy the full SHA
    ae5cb80 View commit details
    Browse the repository at this point in the history

  2. feat: Unknown device type for data-only FTMS machines 

    Add MachineType.UNKNOWN for BLE devices that advertise FTMS UUID but
lack service_data for type detection (e.g. BH Fitness). Unknown machine
subscribes to all data characteristic UUIDs and detects type from
whichever responds.

Also handles missing Feature characteristic gracefully — proceeds in
data-only mode without control point support.
    pafernanr committed Aug 22, 2026
    Configuration menu
    Copy the full SHA
    9c9e0e1 View commit details
    Browse the repository at this point in the history

  3. fix: movement_direction crash, zero-value handling, fw_version fallback 

    - CrossTrainerData.movement_direction: add model_meta() so serializer
  skips the non-init field instead of crashing
- Filter with `is not None` instead of truthiness — zero values (0 W,
  0 km/h) are valid FTMS data, not null packets
- Handle truncated BLE data gracefully (EOFError catch, log extra bytes)
- Add fw_version GATT characteristic read with sw_version fallback
- Skip non-init fields in model serializer (field.init check)
    pafernanr committed Aug 22, 2026
    Configuration menu
    Copy the full SHA
    39bb88c View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL