fix: a11y issue on a missing description of that complementary icon · pattern-lab/patternlab-node@4f13807 · GitHub

This repository was archived by the owner on May 13, 2026. It is now read-only.

pattern-lab / patternlab-node Public archive

• Notifications You must be signed in to change notification settings
• Fork 396
• Star 2.1k

• Code
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 4f13807

Browse filesBrowse the repository at this point in the historyBrowse files

mfranzke

committed

fix: a11y issue on a missing description of that complementary icon

Firefox a11y analysis on developer tools is mentioning the missing description on that complementary icon, so we could easily remove it from the accessibility tree

1 parent 7dee3b3 commit 4f13807
Copy full SHA for 4f13807

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/uikit-workshop
  • views-twig/partials
    • patternSection.twig
  • views/partials
    • patternSection.mustache

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/uikit-workshop/views-twig/partials/patternSection.twig‎

Copy file name to clipboardExpand all lines: packages/uikit-workshop/views-twig/partials/patternSection.twig

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -19,7 +19,7 @@
19	19	<button class="pl-c-pattern__extra-toggle pl-js-pattern-extra-toggle" id="pl-pattern-extra-toggle-{{partial.patternPartial}}" data-patternpartial="{{ partial.patternPartial }}" title="View Pattern Info">
20	20	<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--expand">Expand</span>
21	21	<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--collapse">Collapse</span>
22		- <div class="pl-c-pattern__toggle-icon-wrapper">
	22	+ <div class="pl-c-pattern__toggle-icon-wrapper" aria-hidden="true">
23	23	<svg viewBox="0 0 16 16" width="20" height="20" class="pl-c-pattern__toggle-icon pl-c-pattern__toggle-icon--expand">
24	24	<path fill="currentColor" d="M9 11.5l1.5 1.5 5-5-5-5-1.5 1.5 3.5 3.5z"></path>
25	25	<path fill="currentColor" d="M7 4.5l-1.5-1.5-5 5 5 5 1.5-1.5-3.5-3.5z"></path>

Collapse file

‎packages/uikit-workshop/views/partials/patternSection.mustache‎

Copy file name to clipboardExpand all lines: packages/uikit-workshop/views/partials/patternSection.mustache

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -18,7 +18,7 @@
18	18	<button class="pl-c-pattern__extra-toggle pl-js-pattern-extra-toggle" id="pl-pattern-extra-toggle-{{ patternPartial }}" data-patternpartial="{{ patternPartial }}" title="View Pattern Info">
19	19	<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--expand">Expand</span>
20	20	<span class="pl-c-pattern__extra-toggle-text pl-c-pattern__extra-toggle-text--collapse">Collapse</span>
21		- <div class="pl-c-pattern__toggle-icon-wrapper">
	21	+ <div class="pl-c-pattern__toggle-icon-wrapper" aria-hidden="true">
22	22	<svg viewBox="0 0 16 16" width="20" height="20" class="pl-c-pattern__toggle-icon pl-c-pattern__toggle-icon--expand">
23	23	<path fill="currentColor" d="M9 11.5l1.5 1.5 5-5-5-5-1.5 1.5 3.5 3.5z"></path>
24	24	<path fill="currentColor" d="M7 4.5l-1.5-1.5-5 5 5 5 1.5-1.5-3.5-3.5z"></path>

0 commit comments

Comments

0 (0)